Enhance k3s check-config
#7091
Merged
Enhance k3s check-config
#7091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
approved these changes
Mar 14, 2023
cwayne18
approved these changes
Mar 14, 2023
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Mar 29, 2023
* Move CONFIG_CGROUP_PIDS to Required Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Mar 29, 2023
* Move CONFIG_CGROUP_PIDS to Required Signed-off-by: Derek Nola <derek.nola@suse.com>
This was referenced Mar 29, 2023
dereknola
added a commit
that referenced
this pull request
Mar 29, 2023
* Add missing kernel config checks (#6946) Add additional kernel config checks for NETFILTER_XT_MATCH_COMMENT and NETFILTER_XT_MATCH_MULTIPORT as they are both required to run k3s. Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud> * Enhance `k3s check-config` (#7091) * Move CONFIG_CGROUP_PIDS to Required Signed-off-by: Derek Nola <derek.nola@suse.com> --------- Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud> Signed-off-by: Derek Nola <derek.nola@suse.com> Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
dereknola
added a commit
that referenced
this pull request
Mar 29, 2023
* Add missing kernel config checks (#6946) Add additional kernel config checks for NETFILTER_XT_MATCH_COMMENT and NETFILTER_XT_MATCH_MULTIPORT as they are both required to run k3s. Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud> * Enhance `k3s check-config` (#7091) * Move CONFIG_CGROUP_PIDS to Required Signed-off-by: Derek Nola <derek.nola@suse.com> --------- Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud> Signed-off-by: Derek Nola <derek.nola@suse.com> Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
Verification
k3s check-config, validate that something like:Should shows up.
CONFIG_CGROUP_PIDSis now underGenerally Necessary:Testing
Linked Issues
links: aux/iptables should link to iptables-detect.shet al. (1.21.5, recent Fedora/OpenSUSE) #4066User-Facing Change
Further Comments