Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes 1.27.1 #7271

Merged
merged 10 commits into from
Apr 19, 2023
Merged

Kubernetes 1.27.1 #7271

merged 10 commits into from
Apr 19, 2023

Conversation

dereknola
Copy link
Contributor

Signed-off-by: Derek Nola derek.nola@suse.com

Proposed Changes

  • Bump to Klog, moving to Klog v2 where possible
  • Bump to Cri-dockerd
  • Bump to Go 1.20.3

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner April 11, 2023 23:39
@brandond
Copy link
Contributor

brandond commented Apr 14, 2023

I just ran the script at https://gist.github.com/brandond/5346acc3108b489fa2208b4eab4a1738#file-k3s-modsync-sh - I don’t know if this got pulled into the distro tools repo, but I shared it a while back.

Whenever there's a new minor (and probably even within patch releases), we need to check to see if we've pinned anything to a version that is now older than what upstream expects. When we do that, Kubernetes can break in interesting ways. I didn't bisect to see which specific module was causing problems, but my money would be on either grpc or runtime-spec.

@dereknola dereknola changed the title Kubernetes 1.27.0 Kubernetes 1.27.1 Apr 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +9.44 🎉

Comparison is base (257fa2c) 9.82% compared to head (970ca66) 19.26%.

❗ Current head 970ca66 differs from pull request most recent head 121425f. Consider uploading reports for the commit 121425f to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7271      +/-   ##
==========================================
+ Coverage    9.82%   19.26%   +9.44%     
==========================================
  Files         147       81      -66     
  Lines       10845     5471    -5374     
==========================================
- Hits         1065     1054      -11     
+ Misses       9558     4195    -5363     
  Partials      222      222              
Flag Coverage Δ
unittests 19.26% <0.00%> (+9.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/authenticator/passwordfile/passwordfile.go 80.64% <ø> (ø)
pkg/cloudprovider/cloudprovider.go 0.00% <0.00%> (ø)

... and 66 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

dereknola and others added 9 commits April 18, 2023 09:50
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
1. use Docker to create the build container: `echo -e $BUILD_CONTAINER | docker build -t ${GOIMAGE}-dev -`
1. set env variable PATH_TO_KUBERNETES_REPO to the path to your local kubernetes/kubernetes copy:
```
export GHUSER="mtrachier"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: don't embed our individual usernames in docs. Make it clear that this is a placeholder for the user's actual GH username.

@@ -12,7 +12,6 @@
Example Full Command List (this is not a script!):
```
export SSH_MOUNT_PATH="/var/folders/...krzO/agent.452"
export GLOBAL_GITCONFIG_PATH="/Users/mtrachier/.gitconfig"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we have more usernames embedded here :/

Copy link
Contributor Author

@dereknola dereknola Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they were already in the docs... I can open a future PR and rip them out.

Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants