-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes 1.27.1 #7271
Kubernetes 1.27.1 #7271
Conversation
I just ran the script at https://gist.github.com/brandond/5346acc3108b489fa2208b4eab4a1738#file-k3s-modsync-sh - I don’t know if this got pulled into the distro tools repo, but I shared it a while back. Whenever there's a new minor (and probably even within patch releases), we need to check to see if we've pinned anything to a version that is now older than what upstream expects. When we do that, Kubernetes can break in interesting ways. I didn't bisect to see which specific module was causing problems, but my money would be on either grpc or runtime-spec. |
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #7271 +/- ##
==========================================
+ Coverage 9.82% 19.26% +9.44%
==========================================
Files 147 81 -66
Lines 10845 5471 -5374
==========================================
- Hits 1065 1054 -11
+ Misses 9558 4195 -5363
Partials 222 222
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 66 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
1. use Docker to create the build container: `echo -e $BUILD_CONTAINER | docker build -t ${GOIMAGE}-dev -` | ||
1. set env variable PATH_TO_KUBERNETES_REPO to the path to your local kubernetes/kubernetes copy: | ||
``` | ||
export GHUSER="mtrachier" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: don't embed our individual usernames in docs. Make it clear that this is a placeholder for the user's actual GH username.
@@ -12,7 +12,6 @@ | |||
Example Full Command List (this is not a script!): | |||
``` | |||
export SSH_MOUNT_PATH="/var/folders/...krzO/agent.452" | |||
export GLOBAL_GITCONFIG_PATH="/Users/mtrachier/.gitconfig" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we have more usernames embedded here :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they were already in the docs... I can open a future PR and rip them out.
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola derek.nola@suse.com
Proposed Changes
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments