ensure that klog verbosity is set to the same level as logrus

[thomasferrandiz]

Init klog v2 with the same V level set for logrus so that the verbosity level is correct in components that use klog, especially kube-router.

Proposed Changes

Types of Changes

Verification

start k3s with -v 4 option and check that the logs from kube-router and k8s components are more verbose.

Testing

Linked Issues

#7357

User-Facing Change

Further Comments

[brandond]

The problem you're running into is that the klog flags are a process global, so all the other Kubernetes components that we run in the same process also call InitFlags and try to set the verbosity level - which results in it getting reset whenever we start another component.

This might fix your specific problem as long as the network policy controller is the last thing to be run, but it does not fix the more general issue of components fighting over the K3s process-global log level.

[brandond]

I will also note that we already make the same call here:

k3s/pkg/cli/cmds/log.go

Line 76 in 8d0255a

flag.Set("v", strconv.Itoa(LogConfig.VLevel))

This is run in the same process as kube-router, it's just that the level is later tweaked by other components as described above.

[rbrtbnfgl]

Do we need to investigate further on this or this modification is enough?
I tried to call InitLogging() instead of the PR command but I didn't get the logs.

[thomasferrandiz]

I added new commit to use a dedicated Flag set for klog v2 and avoid conflicts with other packages.
Would that work better?

[brandond]

It's not so much that it's wrong as its just... there are a lot of things fighting over the klog log level. This will mostly work, but if some other component happens to be delayed a bit in startup, and changes the log level back, it will "win" and the log level won't be what you want.

A more functional fix would probably be to have the embedded executor's Bootstrap function start a goroutine that periodically sets the log level back to what we want. There will still be brief periods where other components temporarily set it to the wrong value, but at least that way it would be set to what we want most of the time.

k3s/pkg/daemons/executor/embed.go

Lines 48 to 51 in f2bde63

	func (e *Embedded) Bootstrap(ctx context.Context, nodeConfig *daemonconfig.Node, cfg cmds.Agent) error {
	e.nodeConfig = nodeConfig
	return nil
	}

[brandond]

LGTM, but the PR title probably needs updating now.