Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.26] Adding cli to custom klipper helm image #7914

Conversation

brandond
Copy link
Contributor

@brandond brandond commented Jul 7, 2023

Proposed Changes

A new cli flag for changing our klipper helm image that is default

Types of Changes

New feature

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

the default helm-controller job image can now be overridden with the --helm-job-image CLI flag

Further Comments

Adding cli to custom klipper helm image

Signed-off-by: Vitor Savian <vitor.savian@suse.com>
(cherry picked from commit 0809187)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner July 7, 2023 21:29
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (49b549e) 10.00% compared to head (0de1231) 10.00%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.26    #7914      +/-   ##
================================================
- Coverage         10.00%   10.00%   -0.01%     
================================================
  Files               150      150              
  Lines             10925    10928       +3     
================================================
  Hits               1093     1093              
- Misses             9607     9610       +3     
  Partials            225      225              
Flag Coverage Δ
unittests 10.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cli/cmds/server.go 0.00% <ø> (ø)
pkg/cli/server/server.go 0.00% <0.00%> (ø)
pkg/daemons/config/types.go 67.21% <ø> (ø)
pkg/server/server.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brandond brandond merged commit e200425 into k3s-io:release-1.26 Jul 7, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants