Adding cli to custom klipper helm image #7682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitor Savian <vitor.savian@suse.com>
brandond
requested changes
Jun 7, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7682 +/- ##
==========================================
+ Coverage 47.55% 49.67% +2.11%
==========================================
Files 141 140 -1
Lines 14347 14450 +103
==========================================
+ Hits 6823 7178 +355
+ Misses 6442 6078 -364
- Partials 1082 1194 +112
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
brandond
approved these changes
Jun 12, 2023
galal-hussein
approved these changes
Jun 14, 2023
Signed-off-by: Vitor Savian <vitor.savian@suse.com>
Signed-off-by: Vitor Savian <vitor.savian@suse.com>
vitorsavian
force-pushed
the
add-custom-klipper-image-cli
branch
from
cefa5cd
to
109fe12
Compare
This was referenced Jul 7, 2023
brandond
pushed a commit
to brandond/k3s
that referenced
this pull request
Jul 7, 2023
Adding cli to custom klipper helm image Signed-off-by: Vitor Savian <vitor.savian@suse.com> (cherry picked from commit 0809187) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
pushed a commit
to brandond/k3s
that referenced
this pull request
Jul 7, 2023
Adding cli to custom klipper helm image Signed-off-by: Vitor Savian <vitor.savian@suse.com> (cherry picked from commit 0809187) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
pushed a commit
to brandond/k3s
that referenced
this pull request
Jul 7, 2023
Adding cli to custom klipper helm image Signed-off-by: Vitor Savian <vitor.savian@suse.com> (cherry picked from commit 0809187) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
pushed a commit
that referenced
this pull request
Jul 7, 2023
Adding cli to custom klipper helm image Signed-off-by: Vitor Savian <vitor.savian@suse.com> (cherry picked from commit 0809187) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
pushed a commit
that referenced
this pull request
Jul 7, 2023
Adding cli to custom klipper helm image Signed-off-by: Vitor Savian <vitor.savian@suse.com> (cherry picked from commit 0809187) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
pushed a commit
that referenced
this pull request
Jul 7, 2023
Adding cli to custom klipper helm image Signed-off-by: Vitor Savian <vitor.savian@suse.com> (cherry picked from commit 0809187) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
A new cli flag for changing our klipper helm image that is default
Types of Changes
New feature
Verification
See linked issue
Testing
Linked Issues
#3865
User-Facing Change
Further Comments