New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for using base template in etc/containerd/config.toml.tmpl #7991
Add support for using base template in etc/containerd/config.toml.tmpl #7991
Conversation
…ml.tmpl Signed-off-by: Simon Kirsten <simonkirsten24@gmail.com>
Thanks! Would you mind opening an issue describing the problem you're trying to solve, so that our QA folks have something to work against for validation? |
Thanks for the contribution! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7991 +/- ##
==========================================
+ Coverage 46.94% 51.42% +4.48%
==========================================
Files 143 143
Lines 14561 14562 +1
==========================================
+ Hits 6836 7489 +653
+ Misses 6629 5883 -746
- Partials 1096 1190 +94
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…ml.tmpl (k3s-io#7991) Signed-off-by: Simon Kirsten <simonkirsten24@gmail.com> Signed-off-by: Ikko Eltociear Ashimine <eltociear@gmail.com>
…ml.tmpl (k3s-io#7991) Signed-off-by: Simon Kirsten <simonkirsten24@gmail.com> (cherry picked from commit 546dc24)
…ml.tmpl (k3s-io#7991) Signed-off-by: Simon Kirsten <simonkirsten24@gmail.com> (cherry picked from commit 546dc24) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
…ml.tmpl (k3s-io#7991) Signed-off-by: Simon Kirsten <simonkirsten24@gmail.com> (cherry picked from commit 546dc24) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
…ml.tmpl (k3s-io#7991) Signed-off-by: Simon Kirsten <simonkirsten24@gmail.com> (cherry picked from commit 546dc24) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
…ml.tmpl (k3s-io#7991) Signed-off-by: Simon Kirsten <simonkirsten24@gmail.com> (cherry picked from commit 546dc24) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Proposed Changes
Right now you need copy-paste the default containerd config template from github into
config.toml.tmpl
only to add a few lines.This PR allows to do 👇 instead which is much cleaner and removes the need to keep the base template up-to-date from ☝️ :
/var/lib/rancher/k3s/agent/etc/containerd/config.toml.tmpl
Types of Changes
The PR adds the base template to the template list, so that it can be used.
Verification
cat config.toml
Testing
Linked Issues
User-Facing Change
Further Comments