-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Expand #7991 to not just append blindly #9246
Comments
That is not how golang templates work. Doing what you are asking would require adding support for parsing, merging, and re-marshaling the TOML config files, and we do not have plans to do so. If using |
Why not though? Due to maintenance burden or something related? |
Because we already have a way to accomplish your goal of customizing the containerd config, in a way that does not require us to develop, maintain, and test additional code that mangles the TOML. |
Is your feature request related to a problem? Please describe.
I'm frustrated when I tried to include new cri options, but instead it results in duplicate entries.
Describe the solution you'd like
I would like it to be smarter when appending, so that it would merge the values together if otherwise would result in duplicates.
Describe alternatives you've considered
N/A
Additional context
Related to: #7991
I tried to configure cri with:
but that results in duplicates with the existing cri definition.
The text was updated successfully, but these errors were encountered: