Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Expand #7991 to not just append blindly #9246

Closed
samip5 opened this issue Jan 16, 2024 · 3 comments
Closed

FR: Expand #7991 to not just append blindly #9246

samip5 opened this issue Jan 16, 2024 · 3 comments

Comments

@samip5
Copy link

samip5 commented Jan 16, 2024

Is your feature request related to a problem? Please describe.
I'm frustrated when I tried to include new cri options, but instead it results in duplicate entries.

Describe the solution you'd like
I would like it to be smarter when appending, so that it would merge the values together if otherwise would result in duplicates.

Describe alternatives you've considered
N/A

Additional context
Related to: #7991

I tried to configure cri with:

[plugins."io.containerd.grpc.v1.cri"]
device_ownership_from_security_context = true

but that results in duplicates with the existing cri definition.

@brandond
Copy link
Contributor

brandond commented Jan 16, 2024

That is not how golang templates work. Doing what you are asking would require adding support for parsing, merging, and re-marshaling the TOML config files, and we do not have plans to do so.

If using {{ template "base" . }} does not work for you because you need to modify one of the existing sections, then you should provide a full template.

@samip5
Copy link
Author

samip5 commented Jan 16, 2024

Doing what you are asking would require adding support for parsing, merging, and re-marshaling the TOML config files, and we do not have plans to do so.

Why not though? Due to maintenance burden or something related?
I'm not trying to be a pain, but I just want to understand the reason.

@brandond
Copy link
Contributor

brandond commented Jan 16, 2024

Because we already have a way to accomplish your goal of customizing the containerd config, in a way that does not require us to develop, maintain, and test additional code that mangles the TOML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done Issue
Development

No branches or pull requests

2 participants