[CF] Unit test for MustFindString #8013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #8013 +/- ##
==========================================
+ Coverage 46.94% 51.43% +4.49%
==========================================
Files 143 143
Lines 14561 14561
==========================================
+ Hits 6836 7490 +654
+ Misses 6629 5882 -747
- Partials 1096 1189 +93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
approved these changes
Jul 19, 2023
briandowns
approved these changes
Jul 19, 2023
eltociear
pushed a commit
to eltociear/k3s
that referenced
this pull request
Aug 1, 2023
Signed-off-by: Derek Nola <derek.nola@suse.com> Signed-off-by: Ikko Eltociear Ashimine <eltociear@gmail.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Aug 3, 2023
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Aug 3, 2023
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Aug 3, 2023
Signed-off-by: Derek Nola <derek.nola@suse.com>
This was referenced Aug 3, 2023
dereknola
added a commit
that referenced
this pull request
Aug 4, 2023
dereknola
added a commit
that referenced
this pull request
Aug 4, 2023
dereknola
added a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Additional unit test for
MustFindString. Easy code cov win.Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments