Consolidate CopyFile functions #8079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
approved these changes
Jul 31, 2023
Signed-off-by: Derek Nola <derek.nola@suse.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #8079 +/- ##
==========================================
+ Coverage 47.07% 51.62% +4.55%
==========================================
Files 143 143
Lines 14561 14586 +25
==========================================
+ Hits 6854 7530 +676
+ Misses 6614 5853 -761
- Partials 1093 1203 +110
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
manuelbuil
approved these changes
Aug 1, 2023
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Aug 3, 2023
* Consolidate CopyFile function Signed-off-by: Derek Nola <derek.nola@suse.com> * Copy to File, not destination folder Signed-off-by: Derek Nola <derek.nola@suse.com> --------- Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Aug 3, 2023
* Consolidate CopyFile function Signed-off-by: Derek Nola <derek.nola@suse.com> * Copy to File, not destination folder Signed-off-by: Derek Nola <derek.nola@suse.com> --------- Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Aug 3, 2023
* Consolidate CopyFile function Signed-off-by: Derek Nola <derek.nola@suse.com> * Copy to File, not destination folder Signed-off-by: Derek Nola <derek.nola@suse.com> --------- Signed-off-by: Derek Nola <derek.nola@suse.com>
This was referenced Aug 3, 2023
dereknola
added a commit
that referenced
this pull request
Aug 4, 2023
dereknola
added a commit
that referenced
this pull request
Aug 4, 2023
dereknola
added a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
We had two nearly identical
CopyFilefunctions in the K3s codebase. This PR consolidates them into one function.Types of Changes
DRY
Verification
Testing
Linked Issues
TBD
User-Facing Change
Further Comments