Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.27] Include the interface name in the error message #8435

Merged
merged 1 commit into from Sep 26, 2023

Conversation

manuelbuil
Copy link
Contributor

Backport: #8346
Issue: #8424

@manuelbuil manuelbuil requested a review from a team as a code owner September 26, 2023 08:14
Signed-off-by: Manuel Buil <mbuil@suse.com>
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9750202) 47.14% compared to head (c94e882) 50.47%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27    #8435      +/-   ##
================================================
+ Coverage         47.14%   50.47%   +3.32%     
================================================
  Files               144      144              
  Lines             14637    14642       +5     
================================================
+ Hits               6901     7390     +489     
+ Misses             6633     6065     -568     
- Partials           1103     1187      +84     
Flag Coverage Δ
e2etests 49.01% <53.84%> (?)
inttests 41.65% <0.00%> (-2.81%) ⬇️
unittests 19.90% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/agent/config/config.go 51.97% <0.00%> (+3.23%) ⬆️
pkg/util/net.go 57.14% <75.00%> (+10.03%) ⬆️
pkg/cli/agent/agent.go 26.22% <40.00%> (+26.22%) ⬆️
pkg/cli/server/server.go 51.13% <40.00%> (-7.20%) ⬇️

... and 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuelbuil manuelbuil merged commit eb02e2d into k3s-io:release-1.27 Sep 26, 2023
19 checks passed
@manuelbuil manuelbuil deleted the interfaceLog127 branch September 26, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants