Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.27] Take IPFamily precedence based on order #8504

Merged
merged 2 commits into from Oct 2, 2023

Conversation

manuelbuil
Copy link
Contributor

Backport: #8460
Issue: #8501

Signed-off-by: Manuel Buil <mbuil@suse.com>
Signed-off-by: Manuel Buil <mbuil@suse.com>
@manuelbuil manuelbuil requested a review from a team as a code owner September 29, 2023 10:41
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (b91ce1f) 47.21% compared to head (dbb6280) 51.69%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27    #8504      +/-   ##
================================================
+ Coverage         47.21%   51.69%   +4.47%     
================================================
  Files               144      144              
  Lines             14660    14622      -38     
================================================
+ Hits               6922     7559     +637     
+ Misses             6641     5884     -757     
- Partials           1097     1179      +82     
Flag Coverage Δ
e2etests 49.12% <59.52%> (?)
inttests 44.60% <67.30%> (+0.07%) ⬆️
unittests 19.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/agent/config/config.go 52.44% <100.00%> (+3.70%) ⬆️
pkg/deploy/zz_generated_bindata.go 51.49% <ø> (ø)
pkg/server/server.go 59.07% <100.00%> (+2.32%) ⬆️
pkg/agent/run.go 45.63% <66.66%> (+2.00%) ⬆️
pkg/cluster/cluster.go 40.47% <0.00%> (+0.47%) ⬆️
pkg/daemons/config/types.go 84.44% <0.00%> (ø)
pkg/agent/flannel/setup.go 37.66% <0.00%> (-0.25%) ⬇️
pkg/cli/server/server.go 61.87% <78.57%> (+4.26%) ⬆️
pkg/util/net.go 57.97% <57.14%> (+10.64%) ⬆️

... and 38 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuelbuil manuelbuil merged commit 9a930c6 into k3s-io:release-1.27 Oct 2, 2023
19 checks passed
@manuelbuil manuelbuil deleted the IPPrecedence127 branch October 2, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants