Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dualStack log #8798

Merged
merged 1 commit into from Nov 14, 2023
Merged

Improve dualStack log #8798

merged 1 commit into from Nov 14, 2023

Conversation

manuelbuil
Copy link
Contributor

Proposed Changes

When running dualStack you get the log:

level=info msg="The interface eth0 with ipv4 address 10.1.1.10 will be used by flannel"

Which can be confusing, especially if you are prioritizing IPv6 family.

This PR combines both log entries when we are in dualStack mode so that we get both IPFamilies in the log

Types of Changes

Bugfix

Verification

Testing

Deploy with dualStack cidr and you should see the new log

Linked Issues

#8797

User-Facing Change


Further Comments

@manuelbuil manuelbuil requested a review from a team as a code owner November 8, 2023 08:48
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bbafb86) 47.12% compared to head (70763d6) 47.87%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8798      +/-   ##
==========================================
+ Coverage   47.12%   47.87%   +0.74%     
==========================================
  Files         148      148              
  Lines       15674    15917     +243     
==========================================
+ Hits         7387     7620     +233     
+ Misses       7089     7061      -28     
- Partials     1198     1236      +38     
Flag Coverage Δ
e2etests 47.05% <0.00%> (?)
inttests 38.97% <0.00%> (-5.63%) ⬇️
unittests 17.87% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/agent/flannel/flannel.go 43.31% <0.00%> (+0.27%) ⬆️

... and 51 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Manuel Buil <mbuil@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants