Update Kubernetes to v1.29.0+k3s1 #9052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
reviewed
Dec 13, 2023
galal-hussein
force-pushed
the
v1.29.0-k3s1
branch
2 times, most recently
from
ca4568b
to
e32241e
Compare
brandond
reviewed
Dec 15, 2023
brandond
approved these changes
Dec 15, 2023
brandond
reviewed
Dec 16, 2023
manuelbuil
reviewed
Dec 18, 2023
Comment on lines
+51
to
+53
| #echo Running: golangci-lint | ||
| ## https://github.com/golangci/golangci-lint/issues/2788 | ||
| #CGO_ENABLED=0 golangci-lint run -v |
There was a problem hiding this comment.
why are you commenting this test?
There was a problem hiding this comment.
Discussed in SU. This will be contributed later in a different PR because it is currently breaking
manuelbuil
approved these changes
Dec 18, 2023
brandond
reviewed
Dec 18, 2023
galal-hussein
force-pushed
the
v1.29.0-k3s1
branch
from
746cfe9
to
84186f3
Compare
|
The new one-shot secrets encryption support was broken in v1.29 - as part of moving the feature to GA, it was also refactored to poll the config at 1 minute intervals, instead of using inotify as it did while alpha in v1.28. I'm not sure why upstream permitted a major rework as part of GA promotion, but that's what happened. There is no audit trail for this, as the issue justifying the change literally has no description. Ref: |
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
This update uses k3s' fork of flannel to allow the removal of multicluster cidr flag logic from the code Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: Brad Davidson <brad@oatmail.org>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
galal-hussein
force-pushed
the
v1.29.0-k3s1
branch
from
84186f3
to
408b046
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #9052 +/- ##
==========================================
- Coverage 50.24% 41.62% -8.62%
==========================================
Files 148 148
Lines 15881 15924 +43
==========================================
- Hits 7979 6628 -1351
- Misses 6642 8162 +1520
+ Partials 1260 1134 -126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pierre-az
pushed a commit
to pierre-az/k3s
that referenced
this pull request
Dec 19, 2023
* Update to v1.29.0 Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * Update to v1.29.0 Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * Update go to 1.21.5 Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * update golangci-lint Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * update flannel to 0.23.0-k3s1 This update uses k3s' fork of flannel to allow the removal of multicluster cidr flag logic from the code Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * fix flannel calls Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * update cri-tools to version v1.29.0-k3s1 Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * Remove GOEXPERIMENT=nounified from arm builds Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * Skip golangci-lint Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * Fix setup logging with newer go version Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * Move logging flags to components arguments Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * add sysctl commands to the test script Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> * Update scripts/test Signed-off-by: Brad Davidson <brad@oatmail.org> * disable secretsencryption tests Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> --------- Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> Signed-off-by: Brad Davidson <brad@oatmail.org> Co-authored-by: Brad Davidson <brad@oatmail.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments