Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for etcd-snapshot-dir and fix panic in Walk #9317

Merged
merged 1 commit into from Feb 7, 2024

Conversation

brandond
Copy link
Contributor

Proposed Changes

Add check for etcd-snapshot-dir and fix panic in Walk

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner January 30, 2024 22:50
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 2544 lines in your changes are missing coverage. Please review.

Comparison is base (ce6158f) 49.07% compared to head (c4dd465) 40.51%.
Report is 184 commits behind head on master.

Files Patch % Lines
pkg/etcd/snapshot.go 34.93% 442 Missing and 74 partials ⚠️
pkg/etcd/s3.go 0.00% 233 Missing ⚠️
pkg/etcd/snapshot_controller.go 0.00% 216 Missing ⚠️
pkg/etcd/etcd.go 19.65% 168 Missing and 16 partials ⚠️
pkg/spegel/spegel.go 2.98% 130 Missing ⚠️
pkg/agent/containerd/containerd.go 0.00% 116 Missing ⚠️
pkg/spegel/bootstrap.go 1.81% 108 Missing ⚠️
pkg/apis/k3s.cattle.io/v1/zz_generated_deepcopy.go 17.35% 93 Missing and 7 partials ⚠️
pkg/server/secrets-encrypt.go 0.00% 84 Missing ⚠️
...d/controllers/k3s.cattle.io/v1/etcdsnapshotfile.go 0.00% 75 Missing ⚠️
... and 51 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9317      +/-   ##
==========================================
- Coverage   49.07%   40.51%   -8.56%     
==========================================
  Files         154      154              
  Lines       16416    16560     +144     
==========================================
- Hits         8056     6710    -1346     
- Misses       7090     8700    +1610     
+ Partials     1270     1150     -120     
Flag Coverage Δ
e2etests ?
inttests 37.68% <25.62%> (-4.61%) ⬇️
unittests 14.52% <6.84%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants