Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.28] Backports for 2024-02 release cycle #9462

Merged

Conversation

brandond and others added 10 commits February 9, 2024 23:28
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 4005600)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
The reconcile may run before the kubelet has created the node object; retry until it succeeds

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 82e3c32)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 6ec1926)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Ref: rancher/plugins@v1.3.0-k3s1...v1.4.0-k3s2

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 77ba990)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
The nodes controller was reading from the configmaps cache, but doesn't add any handlers, so if no other controller added configmap handlers, the cache would remain empty.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 888f866)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 8224a3a)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Oleg Matskiv <oleg.matskiv@gmail.com>
(cherry picked from commit e3b237f)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Edgar Lee <edgarhinshunlee@gmail.com>
(cherry picked from commit 14c6c63)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Edgar Lee <edgarhinshunlee@gmail.com>
(cherry picked from commit 0ac4c6a)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit de82584)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner February 9, 2024 23:39
@brandond brandond changed the title [release-1.28] Backports for 2024-03 release cycle [release-1.28] Backports for 2024-02 release cycle Feb 9, 2024
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (dda9780) 49.30% compared to head (f20cb02) 45.87%.

Files Patch % Lines
pkg/rootless/mounts.go 0.00% 14 Missing ⚠️
pkg/cli/etcdsnapshot/etcd_snapshot.go 72.72% 6 Missing and 3 partials ⚠️
pkg/etcd/snapshot.go 14.28% 4 Missing and 2 partials ⚠️
pkg/cluster/cluster.go 50.00% 2 Missing and 1 partial ⚠️
pkg/etcd/etcd.go 90.32% 2 Missing and 1 partial ⚠️
pkg/node/controller.go 40.00% 2 Missing and 1 partial ⚠️
pkg/server/router.go 25.00% 2 Missing and 1 partial ⚠️
pkg/etcd/snapshot_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28    #9462      +/-   ##
================================================
- Coverage         49.30%   45.87%   -3.43%     
================================================
  Files               154      154              
  Lines             16616    16679      +63     
================================================
- Hits               8192     7651     -541     
- Misses             7137     7775     +638     
+ Partials           1287     1253      -34     
Flag Coverage Δ
e2etests ?
inttests 42.76% <59.22%> (+0.71%) ⬆️
unittests 15.08% <18.64%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 3d0674a into k3s-io:release-1.28 Feb 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants