Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netpol startup when flannel is disabled #9571

Merged
merged 1 commit into from Feb 26, 2024

Conversation

brandond
Copy link
Contributor

Proposed Changes

Fix netpol startup when flannel is disabled.

Don't break out of the poll loop if we can't get the node, RBAC might not be ready yet.

Types of Changes

bugfix

Verification

see linked issue

Testing

tbd
/cc @manuelbuil

Linked Issues

User-Facing Change

Further Comments

Don't break out of the poll loop if we can't get the node, RBAC might not be ready yet.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner February 26, 2024 18:54
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 42.91%. Comparing base (fae0d99) to head (7da22c6).

Files Patch % Lines
pkg/agent/netpol/netpol.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9571      +/-   ##
==========================================
- Coverage   49.19%   42.91%   -6.29%     
==========================================
  Files         151      154       +3     
  Lines       13471    13523      +52     
==========================================
- Hits         6627     5803     -824     
- Misses       5506     6552    +1046     
+ Partials     1338     1168     -170     
Flag Coverage Δ
e2etests ?
inttests 39.47% <0.00%> (-0.03%) ⬇️
unittests 15.96% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 86f1021 into k3s-io:master Feb 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants