Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BROKEN: instagram profile #381

Closed
6 tasks done
jkowalleck opened this issue Sep 7, 2020 · 0 comments · Fixed by #392
Closed
6 tasks done

BROKEN: instagram profile #381

jkowalleck opened this issue Sep 7, 2020 · 0 comments · Fixed by #392
Assignees
@jkowalleck
Labels
ImageCrawler broken

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Sep 7, 2020 •
edited

instagram profile crawler is currently broken.

this is due to a change in instagrams javascripts. the needed queryID moved to a different page.
see broken natgeo in current example

  • have fixed master branch
    • write test (find why test is not detecting the issue)
    • adjust tests
    • write a fix
  • have fixed 3.0-dev branch
    • write test (find why test is not detecting the issue)
    • adjust tests
    • write a fix
@jkowalleck jkowalleck added the bug label Sep 7, 2020
jkowalleck added a commit that referenced this issue Sep 8, 2020
@jkowalleck
fix #381
e5d5692
@jkowalleck jkowalleck self-assigned this Sep 8, 2020
jkowalleck added a commit that referenced this issue Sep 9, 2020
@jkowalleck
test #381
35e335e
jkowalleck added a commit that referenced this issue Sep 9, 2020
@jkowalleck
fix #381
418d16a
jkowalleck added a commit that referenced this issue Sep 10, 2020
@jkowalleck
fix for #381
a3e6934
jkowalleck added a commit that referenced this issue Sep 10, 2020
@jkowalleck
fixed tests for #381
ca222c8
jkowalleck added a commit that referenced this issue Sep 10, 2020
@jkowalleck
fix for #381
2440d22
jkowalleck added a commit that referenced this issue Sep 10, 2020
@jkowalleck
fixed tests for #381
b990d9b
jkowalleck added a commit that referenced this issue Sep 10, 2020
@jkowalleck
added #381 fix to hostory
0ecb9e0
jkowalleck added a commit that referenced this issue Sep 10, 2020
@jkowalleck
added #381 fix to hostory
3108160
This was referenced Sep 10, 2020
Merged
Merged
jkowalleck added a commit that referenced this issue Sep 19, 2020
@jkowalleck
Merge pull request #392 from k4cg/3.0-dev_issue_381
8828c65 
3.0 dev issue #381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkowalleck jkowalleck

Labels
ImageCrawler broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3.0 dev issue #381 k4cg/nichtparasoup
1 participant
@jkowalleck