Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve config checks #186

Merged
merged 30 commits into from
Jan 25, 2020
Merged

improve config checks #186

merged 30 commits into from
Jan 25, 2020

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jan 25, 2020

changes:

Breaking changes

  • nichtparasoup config --check's "duplicate image crawler" is no longer a Warning but an Error.
  • renamed nichtparasoup.testing.config.ConfigFileTest to ConfigFileTest - without an "s".

Changes

  • nichtparasoup config --check now does a probe crawl.

Added

  • added additional test function: nichtparasoup.testing.config.ConfigFileTest.probe().

@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jkowalleck
Copy link
Member Author

had a hard time to debug a bug in pytest=5.3.4
fixed by pinning a version<5.3.4
also opened #187

@jkowalleck jkowalleck merged commit 21e556d into k4cg:master Jan 25, 2020
@jkowalleck jkowalleck deleted the check_test_crawl branch January 26, 2020 11:27
@jkowalleck jkowalleck restored the check_test_crawl branch January 28, 2020 22:40
@jkowalleck jkowalleck deleted the check_test_crawl branch October 10, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant