Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: if Secret Mission is aborted, wormhole lights still flash #124

Closed
dobragab opened this issue Jan 20, 2022 · 5 comments
Closed

Bug: if Secret Mission is aborted, wormhole lights still flash #124

dobragab opened this issue Jan 20, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@dobragab
Copy link

Repro steps, although I haven't verified with cheat mode yet:

  • Start a Secret Mission, when you have to shoot the Yellow, then Red, then Green wormhole in order.
  • As a first step, the arrow light for the Yellow wormhole will start flashing.
  • Wait until the mission is aborted due to fuel. Mission aborted, refuel the ship.
  • The white "Refuel" arrow will start flashing, but the Yellow wormhole will keep flashing.
@k4zmu2a k4zmu2a added the bug Something isn't working label Jan 21, 2022
k4zmu2a added a commit that referenced this issue Feb 7, 2022
@k4zmu2a
Copy link
Owner

k4zmu2a commented Feb 7, 2022

This bug is from the original 3DPB.
Fixed by adding wormhole lights reset in SelectMissionController code 66.

@dobragab
Copy link
Author

dobragab commented Feb 7, 2022

👍
I guess your fix applies for all wormhole lights, not just the yellow one.

Just curious: was this present in FT?

@k4zmu2a
Copy link
Owner

k4zmu2a commented Feb 7, 2022

The are three stages of secret mission, each uses different wormhole and lights.
It makes sense to fix mission abort for all of them.

About FT: I don’t know but am curious as well.
I can’t easily do it without hidden test and my decomp does not cover that part yet.
If I figure it out, I’ll write it here.

@k4zmu2a
Copy link
Owner

k4zmu2a commented Feb 8, 2022

FT has this bug as well, as expected.

Some fun facts about FT that I learned:
FT has fully functional hidden test, it is entered with tab instead of space: “hidden\ttest”.
FT runs uncapped at blistering 30000+ UPS, mouse cheat does not work in such conditions.
I worked around this issue by injecting sleep(8) into main loop with CheatEngine.

@dobragab
Copy link
Author

dobragab commented Feb 8, 2022

Cool! I'm not surprised either :)
Thanks!

@dobragab dobragab closed this as completed Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants