Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TABA2.MDS and TABA3.MDS aren't heard during gameplay when using Full Tilt files #129

Closed
LegoLoco7 opened this issue Mar 9, 2022 · 3 comments
Labels
question Further information is requested

Comments

@LegoLoco7
Copy link

LegoLoco7 commented Mar 9, 2022

I love this decompilation and all the features it has, but I did notice a slight issue when playing using the files from Full Tilt! Pinball's Space Cadet, and that is TABA2.MDS and TABA3.MDS aren't played at all during gameplay. This video should give you a basic idea of when those themes are supposed to play if you remake the code for it rather than using the code from the actual game. (In said video, TABA2.MDS appears at 0:17, while TABA3.MDS appears at 17:38.)

The 3D Pinball for Windows - Space Cadet demo doesn't have either of these themes, so the new code could be bypassed if using the demo files or using the Prefer 3DPB Data option with any music-related demo files present.

Though I now realize for TABA3.MDS, you'd have to answer this issue as well. Just thought I'd mention after looking.

I also just realized now that this is already a planned feature. That's good to know, at least. I apologize if I've wasted your time.

@k4zmu2a
Copy link
Owner

k4zmu2a commented Mar 10, 2022

This is a known problem, playback of second and third tracks is not yet implemented.
It is a side effect of project structure: 3DPB code with FT support added on top.

I am not going to add FT things just based on observed behavior, I prefer basing them on decompilation.
Rest assured, I aim to add all FT game play features, eventually.

@k4zmu2a k4zmu2a added the question Further information is requested label Mar 10, 2022
@LegoLoco7
Copy link
Author

I was guessing so.

I'm not exactly sure why you wouldn't do that considering it's just simple music cues, but okay, I guess. I wish you luck.

k4zmu2a added a commit that referenced this issue May 20, 2022
Note that taba3 is not currently played as it needs multiball support.
Issue #129.
k4zmu2a added a commit that referenced this issue May 23, 2022
Cleaned up TCollisionComponent.
Issue #129.
@k4zmu2a
Copy link
Owner

k4zmu2a commented May 26, 2022

Support for all FT midi tracks is now ready in v2 and v1.
TABA3 is currently unreachable because it needs multi ball support.

waptaff pushed a commit to waptaff/SpaceCadetPinball that referenced this issue May 27, 2022
Refactored midi multiple track support.
Cleaned up TCollisionComponent.
Issue k4zmu2a#129.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants