Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flipper animation and angle calculation #150

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

amurzeau
Copy link
Contributor

@amurzeau amurzeau commented Aug 8, 2022

Checked with a slowed down flipper (reduced retractTime and extendTime)
to ensure the flipper position is correct even when not finished while
pressing the flipper control.

Here are videos of the slowed down flippers before and after the patch.

Before this patch, the flipper where always starting their animation from either fully down or fully up, causing glitches when pressing or releasing the flipper button while it is midway:

simplescreenrecorder-2022-08-08_22.10.36.mp4

There is also a weird behavior when losing focus, both flipper trigger:

simplescreenrecorder-2022-08-08_22.17.08.mp4

With this patch, here is the flipper and ball behavior:

simplescreenrecorder-2022-08-08_22.03.05.mp4

There is no more weird behavior, and the ball can't move through the flippers.

With the normal flipper speed this is barely visible, except the moving flippers when losing and regaining focus (this is what led me to find this issue), but this might cause unexpected behaviors when playing.

Checked with a slowed down flipper (reduced retractTime and extendTime)
to ensure the flipper position is correct even when not finished while
pressing the flipper control.
@k4zmu2a k4zmu2a merged commit a2567c1 into k4zmu2a:master Aug 9, 2022
@k4zmu2a
Copy link
Owner

k4zmu2a commented Aug 9, 2022

Thank you, merged.
This is a very nice find; most likely fixes #125.

There was a related bug - 48721e5, frameskip in flipper sprite animation.
FT is more polished in terms of flipper movement; it does not seem to have any of these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants