Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove udp-services ConfigMap creation from k8gb helm chart #352

Closed
somaritane opened this issue Mar 5, 2021 · 0 comments · Fixed by #354
Closed

Remove udp-services ConfigMap creation from k8gb helm chart #352

somaritane opened this issue Mar 5, 2021 · 0 comments · Fixed by #354
Labels
enhancement New feature or request
Milestone
0.8

Comments

@somaritane
Copy link
Contributor

udp-services is ConfigMap that should be configured in NGINX Ingress controller namespace in order to expose UDP services (in case of k8gb we use it to expose DNS port for k8gb-coredns service on workers).
As this config lies outside of k8gb operator responsibility, and serves the need of many services in the cluster, its lifecycle should not be controlled by k8gb helm chart.
@somaritane somaritane added the enhancement New feature or request label Mar 5, 2021
somaritane pushed a commit that referenced this issue Mar 6, 2021
Remove upd-services ConfigMap from k8gb helm chart templates
b22c38b 
- Removes NGINX Ingress Controller `udp-services` ConfigMap from k8gb chart templates.
- Updates k8gb documentation and example values files in order to reflect removal.

This PR closes #352
somaritane pushed a commit that referenced this issue Mar 6, 2021
Remove upd-services ConfigMap from k8gb helm chart templates
edec0af 
- Removes NGINX Ingress Controller `udp-services` ConfigMap from k8gb chart templates.
- Updates k8gb documentation and example values files in order to reflect removal.

This PR closes #352
@somaritane somaritane mentioned this issue Mar 6, 2021
Merged
@somaritane somaritane added this to the 0.8 milestone Mar 10, 2021
somaritane pushed a commit that referenced this issue Mar 10, 2021
Remove upd-services ConfigMap from k8gb helm chart templates
9fb3e33 
- Removev NGINX Ingress Controller `udp-services` ConfigMap from k8gb chart templates.
- Updated k8gb documentation and example values files in order to reflect removal.
- Added `udp-services` patching for local setup to Makefile
- Created documentation explaining DNS traffic configuration
- Amended general and local setup documentation

This PR closes #352 and #323
somaritane pushed a commit that referenced this issue Mar 10, 2021
Remove upd-services ConfigMap from k8gb helm chart templates
724da62 
- Removed NGINX Ingress Controller `udp-services` ConfigMap from k8gb chart templates.
- Updated k8gb documentation and example values files in order to reflect removal.
- Added `udp-services` patching for local setup to Makefile
- Created documentation explaining DNS traffic configuration
- Amended general and local setup documentation

This PR closes #352 and #323
somaritane pushed a commit that referenced this issue Mar 10, 2021
Remove upd-services ConfigMap from k8gb helm chart templates
397c949 
- Removed NGINX Ingress Controller `udp-services` ConfigMap from k8gb chart templates.
- Updated k8gb documentation and example values files in order to reflect removal.
- Created documentation explaining DNS traffic configuration
- Amended general and local setup documentation

This PR closes #352 and #323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.8
Development

Successfully merging a pull request may close this issue.

Remove udp-services ConfigMap from k8gb helm chart templates k8gb-io/k8gb
1 participant
@somaritane