NS1 support #217
Merged
NS1 support #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ytsarev
commented
Dec 13, 2020
•
ytsarev
commented
- Chart extension for external-dns based ns1 provider
- Move common code between route53 and NS1(and potentially other providers) to separate function
- Depresolver extension with NS1 provider type
- Depresolver and controller tests
- Chart version bump
ytsarev
requested review from
donovanmuller,
k0da,
kuritka and
somaritane
as code owners
|
LGTM |
kuritka
previously approved these changes
Dec 14, 2020
somaritane
suggested changes
Dec 14, 2020
|
|
Co-authored-by: Donovan Muller <donovan.muller@gmail.com>
Co-authored-by: Donovan Muller <donovan.muller@gmail.com>
kuritka
requested changes
Dec 15, 2020
| @@ -86,3 +86,7 @@ spec: | |||
| - name: ROUTE53_ENABLED | |||
| value: "true" | |||
| {{ end }} | |||
| {{ if .Values.ns1.enabled }} | |||
| - name: NS1_ENABLED | |||
| value: "true" | |||
There was a problem hiding this comment.
does helm support something like this ?
- name: ROUTE53_ENABLED
value: {{ .Values.route53.enabled }}
- name: NS1_ENABLED
value: {{ .Values.ns1.enabled }}
There was a problem hiding this comment.
@kuritka maybe but it will be declared but empty variables, do not think we want to pollute the environment with them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.