Stabilize local setup #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytsarev
requested review from
donovanmuller,
k0da,
kuritka and
somaritane
as code owners
k0da
reviewed
Apr 15, 2021
CONTRIBUTING.md
Outdated
| ### Local setup | ||
|
|
||
| ```sh | ||
| make make deploy-full-local-setup |
There was a problem hiding this comment.
thanks for the catch, amended
There was a problem hiding this comment.
basically lgtm, but do we need deploy-full-local-setup anymore ?
taking back, forget it.. .
* Deploy stable helm chart together with stable k8gb controller version * Deploy test helm chart together with temporary test build of k8gb controller from current tree * Update contributor documentation * Resolves #446 Signed-off-by: Yury Tsarev <yury.tsarev@absa.africa>
ytsarev
force-pushed
the
stabilize-local-setup
branch
from
8f274ae
to
01546bd
Compare
kuritka
approved these changes
Apr 15, 2021
somaritane
reviewed
Apr 15, 2021
somaritane
reviewed
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controller from current tree
Signed-off-by: Yury Tsarev yury.tsarev@absa.africa