Remove K8GB_VERSION env var #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We keep K8GB_VERSION within `operator.yaml` which is not used anywhere. The k8gb version including commit hash is compiled into executable and logged at startup. see: https://github.com/k8gb-io/k8gb/blob/master/.goreleaser.yml#L18 Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
requested review from
donovanmuller,
jkremser,
k0da,
somaritane and
ytsarev
as code owners
k0da
approved these changes
Nov 11, 2021
jkremser
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep
K8GB_VERSIONwithinoperator.yamland is not used anywhere, besides I see here the problem of a single source of truth. The k8gb version including commit hash is compiled into executable and logged at startup, also provided through the metrics.see: https://github.com/k8gb-io/k8gb/blob/master/.goreleaser.yml#L18
Signed-off-by: kuritka kuritka@gmail.com