Weight Round Robin (3/4) - Endpoint #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane,
ytsarev and
jkremser
as code owners
k0da
reviewed
Jun 22, 2022
kuritka
force-pushed
the
wrr-3-annotation-merge
branch
from
e6ef1dc
to
e0712dd
Compare
kuritka
changed the title
kuritka
changed the title
kuritka
force-pushed
the
wrr-3-annotation-merge
branch
4 times, most recently
from
ca196cf
to
cf9808b
Compare
related to #50 implemented code that adds labels to the local dnsEndpoint. - covered by unit-tests - the labels are as follows: ```yaml kind: GSLB spec: ingress: rules: - host: roundrobin.cloud.example.com http: # This section mirrors the same structure as that of an Ingress resource and will be used verbatim when creating the corresponding Ingress resource that will match the GSLB host paths: - path: / backend: service: name: existing-app # Gslb should reflect NotFound status port: name: http spec: strategy: roundRobin weight: eu: 35% us: 50% za: 15% ``` has local DNS endpoint like this: ```yaml apiVersion: externaldns.k8s.io/v1alpha1 kind: DNSEndpoint metadata: name: app_host annotations: k8gb.absa.oss/dnstype: local spec: endpoints: - dnsName: app.bar.com labels: weight-eu-0-35: 10.10.0.1 weight-eu-1-35: 10.10.0.2 weight-us-0-50: 10.0.0.1 weight-us-1-50: 10.0.0.2 weight-za-0-15: 10.22.0.1 weight-za-1-15: 10.22.0.2 weight-za-2-15: 10.22.1.1 recordTTL: 180 recordType: A Targets: - 10.10.0.1 - 10.10.0.2 - 10.0.0.1 - 10.0.0.2 - 10.22.0.1 - 10.22.0.2 - 10.22.1.1 ``` Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
force-pushed
the
wrr-3-annotation-merge
branch
from
cf9808b
to
bef0d68
Compare
kuritka
added a commit
that referenced
this pull request
Jul 1, 2022
Please review after #914 merged I had to prepare one extra terratest to verify that #914 is creating labels correctly. The terratests that control the weight will come later. Together with the test I extended the utils with DNSEndpoint class, which returns information about DNS endpoint. Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
added a commit
that referenced
this pull request
Jul 1, 2022
Please review after #914 merged I had to prepare one extra terratest to verify that #914 is creating labels correctly. The terratests that control the weight will come later. Together with the test I extended the utils with DNSEndpoint class, which returns information about DNS endpoint. Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
added a commit
that referenced
this pull request
Jul 12, 2022
I had to prepare one extra terratest to verify that #914 is creating labels correctly. The terratests that control the weight will come later. Together with the test I extended the utils with DNSEndpoint class, which returns information about DNS endpoint. Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
added a commit
that referenced
this pull request
Jul 25, 2022
I had to prepare one extra terratest to verify that #914 is creating labels correctly. The terratests that control the weight will come later. Together with the test I extended the utils with DNSEndpoint class, which returns information about DNS endpoint. Signed-off-by: kuritka <kuritka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #50
spec.strategy.weightdefines balancing for whole DNSEndpoint (GSLB). To define weight perDNSEndpoint.spec.endpoints[...], thespec.endpoint[].namewould be defined inGSLB.spec.weight.implemented code that adds labels to the local dnsEndpoint.
has local DNS endpoint like this:
Signed-off-by: kuritka kuritka@gmail.com