-
Notifications
You must be signed in to change notification settings - Fork 622
[omada-controller] Provide useful defaults #1632
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,15 +26,48 @@ service: | |
ports: | ||
http: | ||
port: 8043 | ||
management: | ||
enabled: false | ||
ports: | ||
tcp29811: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it be possible to add descriptive names to these ports? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI, 29811, 29812, 29813 are all device upgrade/management ports. |
||
enabled: true | ||
port: 29811 | ||
protocol: TCP | ||
primary: false | ||
tcp29812: | ||
enabled: true | ||
port: 29812 | ||
protocol: TCP | ||
primary: false | ||
tcp29813: | ||
enabled: true | ||
port: 29813 | ||
protocol: TCP | ||
primary: false | ||
discovery: | ||
enabled: false | ||
ports: | ||
udp29810: | ||
enabled: true | ||
port: 29810 | ||
protocol: UDP | ||
primary: false | ||
|
||
ingress: | ||
# -- Enable and configure ingress settings for the chart under this key. | ||
# @default -- See values.yaml | ||
main: | ||
enabled: false | ||
# annotations: | ||
# nginx.ingress.kubernetes.io/backend-protocol: HTTPS | ||
# nginx.ingress.kubernetes.io/proxy-redirect-from: https://$http_host:8043/ | ||
# nginx.ingress.kubernetes.io/proxy-redirect-to: https://$http_host/ | ||
# nginx.ingress.kubernetes.io/configuration-snippet: | | ||
# proxy_set_header Host $http_host:8043; | ||
Comment on lines
+61
to
+66
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We try to keep our charts Ingress-agnostic. I don't know the Omada controller well enough, but I'm also not sure all 4 of these are 100% required? I can imagine that it depends on how the rest of the Ingress (controller) is set up. |
||
|
||
# -- Configure persistence settings for the chart under this key. | ||
# @default -- See values.yaml | ||
persistence: | ||
data: | ||
enabled: false | ||
mountPath: /opt/tplink/EAPController/data | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it really adds much value to run three separate Services for this. Could you please take a look at how the Unifi Controller chart (https://github.com/k8s-at-home/charts/blob/master/charts/stable/unifi/values.yaml#L47) handles this, and implement it in a similar way?