operators [O] prometheus (0.47.0) #1054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
|
/merge possible |
1 similar comment
|
/merge possible |
|
Current PR can be merged automatically, but there is missing |
|
DCO is missing. Please signoff your commits !!! |
|
Current PR can be merged automatically, but there is missing |
|
DCO is missing. Please signoff your commits !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thanks to #1045 for mentioning
the operator tries to monitor all namespaces even in single namespace installation.
when the installation will be namespace scoped, the operator should work as previously.
when the operator is installed cluster scoped, he will manage all the serviceMonitors, prometheusRules... in all namespaces, and the prometheus, alertmanager instances only in his namespace.
i didnt checked the cluster scoped option yet, but the namespace scoped work as always worked before.
(i hope the signoff will work now)