Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator cluster-aas-operator (0.1.5) #4467

Conversation

amisstea
Copy link
Contributor

@amisstea amisstea commented Jun 6, 2024

Thanks submitting your Operator. Please check below list before you create your Pull Request.

New Submissions

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

@amisstea
Copy link
Contributor Author

amisstea commented Jun 6, 2024

Attn @rawagner

@openshift-ci openshift-ci bot requested review from mporrato and tomasbakk June 6, 2024 20:22
Copy link
Contributor

github-actions bot commented Jun 6, 2024

@jtomasek,@mareklibra,@rawagner , please approve as you are original reviewer(s).

  • To add more contributors to ci.yaml follow instruction here.
  • To approve follow instruction here

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Dear @amisstea,
Some errors and/or warnings were found while doing the check of your operator (cluster-aas-operator/0.1.5) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
⚠️ Value clustertemplate.openshift.io/v1alpha1, Kind=ClusterTemplateSetup: provided API should have an example annotation
⚠️ Value clustertemplate.openshift.io/v1alpha1, Kind=Config: provided API should have an example annotation
⚠️ Value cluster-aas-operator.v0.1.5: owned CRD "clustertemplatesetup.clustertemplate.openshift.io" has an empty description
⚠️ Value cluster-aas-operator.v0.1.5: owned CRD "config.clustertemplate.openshift.io" has an empty description

@rawagner
Copy link
Contributor

rawagner commented Jun 7, 2024

/retest

Copy link
Contributor

github-actions bot commented Jun 7, 2024

/hold

Copy link

openshift-ci bot commented Jun 7, 2024

@rawagner: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

/hold cancel

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Dear @amisstea,
Some errors and/or warnings were found while doing the check of your operator (cluster-aas-operator/0.1.5) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
⚠️ Value clustertemplate.openshift.io/v1alpha1, Kind=ClusterTemplateSetup: provided API should have an example annotation
⚠️ Value clustertemplate.openshift.io/v1alpha1, Kind=Config: provided API should have an example annotation
⚠️ Value cluster-aas-operator.v0.1.5: owned CRD "clustertemplatesetup.clustertemplate.openshift.io" has an empty description
⚠️ Value cluster-aas-operator.v0.1.5: owned CRD "config.clustertemplate.openshift.io" has an empty description

@rawagner
Copy link
Contributor

rawagner commented Jun 7, 2024

/ok-to-test

Copy link

openshift-ci bot commented Jun 7, 2024

@rawagner: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@amisstea
Copy link
Contributor Author

amisstea commented Jun 7, 2024

@rawagner do you have any clues as to what might be causing the CI failures? I see the controller manager pod is stuck on creation but otherwise I can't tell what the root cause is.

NAME                                                              READY   STATUS              RESTARTS   AGE
032a87f20f524f2ae801033aec7b419a1e79e44f8a5d7dceb818fc99ffgvmsk   0/1     Completed           0          14m
4858040cc62e08946163366ac7a2b19fd92030ef61522d70256b218b0fdjdsl   0/1     Completed           0          14m
argocd-operator-controller-manager-b6898f485-vxl4g                1/1     Running             0          14m
cluster-aas-operator-controller-manager-6fd44c4849-5vdf8          0/2     ContainerCreating   0          14m
test-operators-ocs-9q24j                                          1/1     Running             0          15m
test-operators-ocs-prod-9zl4w                                     1/1     Running             0          15m

I can pull the image I used (quay.io/stolostron/cluster-templates-operator:2.11.0-0c3131154065397d37e3b66ae635d7ea88650bf9) without issue.

@rawagner
Copy link
Contributor

@amisstea Im not sure. Can you force-push to trigger the tests again ?

@amisstea amisstea force-pushed the cluster-aas-operator.v0.1.5 branch from 464e7a9 to ceac04d Compare June 10, 2024 12:58
Copy link
Contributor

Dear @amisstea,
Some errors and/or warnings were found while doing the check of your operator (cluster-aas-operator/0.1.5) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
⚠️ Value clustertemplate.openshift.io/v1alpha1, Kind=ClusterTemplateSetup: provided API should have an example annotation
⚠️ Value clustertemplate.openshift.io/v1alpha1, Kind=Config: provided API should have an example annotation
⚠️ Value cluster-aas-operator.v0.1.5: owned CRD "clustertemplatesetup.clustertemplate.openshift.io" has an empty description
⚠️ Value cluster-aas-operator.v0.1.5: owned CRD "config.clustertemplate.openshift.io" has an empty description

Signed-off-by: Alex Misstear <amisstea@redhat.com>
@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation
Copy link
Collaborator

/merge possible

Copy link
Contributor

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

Copy link
Contributor

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

@amisstea amisstea requested a review from rawagner June 20, 2024 03:19
@amisstea
Copy link
Contributor Author

@rawagner please merge this when you get a chance.

@rawagner
Copy link
Contributor

/hold

@rawagner
Copy link
Contributor

/hold cancel

@framework-automation
Copy link
Collaborator

/merge possible

1 similar comment
@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation framework-automation merged commit 0b1c2d2 into k8s-operatorhub:main Jun 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants