Fix linter warning message #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1061123
force-pushed
the
fix/liner-warning
branch
from
915f004
to
f3af119
Compare
nicklesimba
reviewed
Apr 5, 2023
| if err := os.Setenv("CNI_ARGS", cniArgs); err != nil { | ||
| return err | ||
| } | ||
| return nil | ||
| return os.Setenv("CNI_ARGS", cniArgs) |
There was a problem hiding this comment.
Is CNI_ARGS going to be the new default instead of returning nil? And what is the reason for this change?
Comment on lines
-240
to
+237
| if err := os.Unsetenv("CNI_ARGS"); err != nil { | ||
| return err | ||
| } | ||
| return nil | ||
| return os.Unsetenv("CNI_ARGS") |
| func (fe *fakeExec) FindInPath(plugin string, paths []string) (string, error) { | ||
| func (fe *fakeExec) FindInPath(_ string, _ []string) (string, error) { |
There was a problem hiding this comment.
Why have argument names been removed for many functions? What is the need for this?
There was a problem hiding this comment.
Make peace with the linter ? It is complaining these attributes are not being used.
Thus we tell the compiler we don't care enough to name them.
... this needs to happen because this is a method of an interface.
There was a problem hiding this comment.
Thanks Miguel, also talked to Tomo about the changes. I think we're good to merge here
nicklesimba
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix linter/revive warning message.