Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump to fedora:38 in dockerized tests, because 34 is missing, bump Multus, OVS, and kubevirtci #268

Merged
merged 2 commits into from
May 10, 2023
Merged

fix: bump to fedora:38 in dockerized tests, because 34 is missing, bump Multus, OVS, and kubevirtci #268

merged 2 commits into from
May 10, 2023

Conversation

courtland
Copy link
Contributor

What this PR does / why we need it:

quay.io pulled docker images for fedora:34

Special notes for your reviewer:

Fixes #267

Release note:

Fix dockerized tests after Fedora 34 EOL

@courtland
fix: bump to fedora:38 in dockerized tests, because 34 is missing
4ca57aa 
Signed-off-by: Nick Rogers <ncrogers@gmail.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 5, 2023
@kubevirt-bot
Copy link
Collaborator

Hi @courtland. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 5, 2023
@phoracek
Copy link
Member

phoracek commented May 8, 2023

/retest

@phoracek
Copy link
Member

phoracek commented May 8, 2023

CI failed installing dependencies on the e2e test cluster:

 + ./cluster/cli.sh ssh node01 -- sudo dnf install -y centos-release-nfv-openvswitch
selecting podman as container runtime
CentOS-8 - NFV OpenvSwitch                      8.2 kB/s | 3.0 kB     00:00    
CentOS-8 - NFV OpenvSwitch                      139 kB/s | 236 kB     00:01    
CentOS Stream 8 - AppStream                      12 kB/s | 4.4 kB     00:00    
CentOS Stream 8 - AppStream                      26 MB/s |  29 MB     00:01    
CentOS Stream 8 - BaseOS                        9.6 kB/s | 3.9 kB     00:00    
CentOS Stream 8 - BaseOS                         17 MB/s |  33 MB     00:01    
CentOS Stream 8 - Extras                         10 kB/s | 2.9 kB     00:00    
CentOS Stream 8 - Extras common packages         16 kB/s | 3.0 kB     00:00    
CentOS Stream 8 - Extras common packages         13 kB/s | 6.4 kB     00:00    
Stable Releases of Upstream github.com/containe  64 kB/s | 1.7 kB     00:00    
Stable Releases of Upstream github.com/containe 623 kB/s |  66 kB     00:00    
devel:kubic:libcontainers:stable:cri-o:1.22 (Ce 1.6 kB/s | 248  B     00:00    
Errors during downloading metadata for repository 'devel_kubic_libcontainers_stable_cri-o_1.22':
  - Status code: 404 for https://storage.googleapis.com/kubevirtci-crio-mirror/devel_kubic_libcontainers_stable_cri-o_1.22/repodata/repomd.xml (IP: 142.250.138.128)
Error: Failed to download metadata for repo 'devel_kubic_libcontainers_stable_cri-o_1.22': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried

Trying again, in case it was a temporary issue. If not, we will probably need to fix the CI environment.

@phoracek
Copy link
Member

phoracek commented May 8, 2023

/retest

@phoracek
Copy link
Member

phoracek commented May 9, 2023

Checking if bump of kubevirtci and OVS helps: #270

@phoracek
Bump kubevirtci, Multus and OVS
e1fbdb2 
These dependencies were quite outdated and did not pass on CI anymore.

This patch brings them up to date.

Signed-off-by: Petr Horacek <hrck@protonmail.com>
@phoracek
Copy link
Member

phoracek commented May 9, 2023

/retest

1 similar comment
@phoracek
Copy link
Member

phoracek commented May 9, 2023

/retest

@phoracek
Copy link
Member

phoracek commented May 9, 2023

/retest

Giving last chance to the flaky test.

@courtland
Copy link
Contributor Author

/retest

Giving last chance to the flaky test.

Hah it worked!

@phoracek phoracek changed the title fix: bump to fedora:38 in dockerized tests, because 34 is missing fix: bump to fedora:38 in dockerized tests, because 34 is missing, bump Multus, OVS, and kubevirtci May 10, 2023
@phoracek
Copy link
Member

/lgtm
/approve

Wonderful! Thanks for the fix @courtland

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: courtland, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@phoracek
Copy link
Member

/override pull-e2e-ovs-cni

@phoracek
Copy link
Member

/retest

1 similar comment
@phoracek
Copy link
Member

/retest

@phoracek
Copy link
Member

/retest

Sorry about the flaky CI.

@kubevirt-bot
Copy link
Collaborator

@courtland: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-ovs-cni e1fbdb2 link true /test pull-e2e-ovs-cni

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@phoracek
Copy link
Member

Merging manually. The test failure is not related to the PR.

@phoracek phoracek merged commit 9603d84 into k8snetworkplumbingwg:main May 10, 2023
@courtland
Copy link
Contributor Author

/retest

Sorry about the flaky CI.

It's all good. What would any CI be without some flakes? :D

Thanks for your help in getting this through.

@phoracek
Copy link
Member

Thank you for pushing this forward! Much appreciated o/

oshoval
oshoval reviewed Oct 1, 2023
View reviewed changes
cluster/up.sh
Comment on lines 26 to +29
./cluster/cli.sh ssh ${node} -- sudo systemctl daemon-reload
./cluster/cli.sh ssh ${node} -- sudo systemctl enable openvswitch
./cluster/cli.sh ssh ${node} -- sudo systemctl restart openvswitch
./cluster/cli.sh ssh ${node} -- sudo systemctl restart NetworkManager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sudo systemctl enable --now openvswitch
should be enough right ?
this what we are doing on CNAO
the cluster is recreated from scratch, so the file system is refreshed and NM is fresh started as well

@phoracek
Copy link
Member

/cherry-pick release-0.29

@kubevirt-bot
Copy link
Collaborator

@phoracek: #268 failed to apply on top of branch "release-0.29":

Applying: fix: bump to fedora:38 in dockerized tests, because 34 is missing
Applying: Bump kubevirtci, Multus and OVS
Using index info to reconstruct a base tree...
M	cluster/cluster.sh
Falling back to patching base and 3-way merge...
Auto-merging cluster/cluster.sh
CONFLICT (content): Merge conflict in cluster/cluster.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Bump kubevirtci, Multus and OVS
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oshoval
Copy link
Member

oshoval commented Oct 30, 2023

@phoracek
note please that if you take this you will need also those maybe
#281
#282

they are due to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshoval oshoval oshoval left review comments

Assignees

@phoracek phoracek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dockerized tests fail due to missing Fedora 34 image
4 participants
@courtland @kubevirt-bot @phoracek @oshoval