-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multus: Pin image #282
multus: Pin image #282
Conversation
Since multus doesnt pin image correctly, pin it before deploying multus. See k8snetworkplumbingwg/multus-cni#1170 Signed-off-by: Or Shoval <oshoval@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval, phoracek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We discussed this during the maintainer's call, and... it's more complex than you might think.
Is there a reason why you can't track master for the OVS-CNI CI? Because I think that might actually be beneficial for both projects. |
Hi Using (as this PR does for thin plugin)
with $MULTUS_VERSION as the tag is legit right ? Note that we never used main on the yaml link, we always pinned the version, which is another reason why to not use latest image with static yaml |
Since multus doesnt pin image correctly,
pin it before deploying multus.
See k8snetworkplumbingwg/multus-cni#1170
What this PR does / why we need it:
Special notes for your reviewer:
Release note: