Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ovs cni plugin to support cni version 1.0.0 #313

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Update ovs cni plugin to support cni version 1.0.0 #313

merged 1 commit into from
Jun 3, 2024

Conversation

adrianchiris
Copy link
Contributor

@adrianchiris adrianchiris commented Jun 3, 2024 •
edited
Loading

This PR updates ovs cni(s) to support v1.0.0 of the spec.

Why is this needed?

sriov network operator supports the deployment of ovs-cni as well as the rendering of network-attachment-definition of "ovs secondary networks". today it does so with cniVersion 1.0.0 .

https://github.com/k8snetworkplumbingwg/sriov-network-operator?tab=readme-ov-file#ovsnetwork

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2024
@kubevirt-bot
Copy link
Collaborator

Hi @adrianchiris. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adrianchiris adrianchiris requested a review from SchSeba June 3, 2024 10:42
adrianchiris
adrianchiris commented Jun 3, 2024
View reviewed changes
tests/mirror_test.go
@@ -78,7 +79,7 @@ var testMirrorFunc = func(version string) {
Eventually(func() error {
_, err := clusterApi.ReadFileFromPod(podConsName, "test", "/tcpdump.log")
return err
}, 120 * time.Second, time.Second).Should(Succeed(), "tcpdump did not start in time");
}, 120*time.Second, time.Second).Should(Succeed(), "tcpdump did not start in time")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDE kept removing these spaces around "*" LMK if you prefer i edit the file in vim or smthn and remove this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it passes the CI it's all right

@phoracek
Copy link
Member

phoracek commented Jun 3, 2024

The containerized build is broken. I'm looking into it

@phoracek
Copy link
Member

phoracek commented Jun 3, 2024

Hopefully #315 solves it

@adrianchiris
Copy link
Contributor Author

The containerized build is broken. I'm looking into it

ack thx for looking into it. centos8:stream is EOL since 31.05 :\

@phoracek
Copy link
Member

phoracek commented Jun 3, 2024

Go was also pretty outdated. Should be all set now. Let's see

@phoracek
Copy link
Member

phoracek commented Jun 3, 2024

/release-note-none

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 3, 2024
@phoracek
Copy link
Member

phoracek commented Jun 3, 2024

/test pull-e2e-ovs-cni

@phoracek
Copy link
Member

phoracek commented Jun 3, 2024

@adrianchiris would you please rebase this?

@adrianchiris
Update ovs cni plugin to support cni version 1.0.0
eb0e091 
Signed-off-by: adrianc <adrianc@nvidia.com>
@phoracek
Copy link
Member

phoracek commented Jun 3, 2024

/test pull-e2e-ovs-cni

@phoracek
Copy link
Member

phoracek commented Jun 3, 2024

/test pull-e2e-ovs-cni

 [2/2] STEP 1/4: FROM registry.access.redhat.com/ubi9/ubi-minimal
Trying to pull registry.access.redhat.com/ubi9/ubi-minimal:latest...
Error: creating build container: copying system image from manifest list: determining manifest MIME type for docker://registry.access.redhat.com/ubi9/ubi-minimal:latest: reading manifest sha256:adbac3083c2f340bee7cce4563665a1555901bee048bca6842b4fa0a1e6b875b in registry.access.redhat.com/ubi9/ubi-minimal: received unexpected HTTP status: 502 Bad Gateway

Another flake?

@phoracek
Copy link
Member

phoracek commented Jun 3, 2024

/lgtm
/approve

Thanks @adrianchiris !

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 3, 2024
@SchSeba
Copy link
Collaborator

SchSeba commented Jun 3, 2024

/lgtm
/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianchiris, phoracek, SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit 9c77f01 into k8snetworkplumbingwg:main Jun 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek phoracek left review comments

@SchSeba SchSeba Awaiting requested review from SchSeba

Assignees

@phoracek phoracek

@SchSeba SchSeba

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adrianchiris @kubevirt-bot @phoracek @SchSeba