Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go to 1.21 #315

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Bump go to 1.21 #315

merged 2 commits into from
Jun 3, 2024

Conversation

phoracek
Copy link
Member

@phoracek phoracek commented Jun 3, 2024

Go 1.18 is old and no longer available in CentOS repositories.

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 3, 2024
@phoracek phoracek mentioned this pull request Jun 3, 2024
Merged
@phoracek
Bump go to 1.21
26594dc 
Go 1.18 is old and no longer available in CentOS repositories.

Signed-off-by: Petr Horacek <phoracek@redhat.com>
e0ne
e0ne approved these changes Jun 3, 2024
View reviewed changes
Copy link

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: e0ne, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@phoracek
Copy link
Member Author

phoracek commented Jun 3, 2024

/retest

 Summarizing 1 Failure:
[Fail] CNI Plugin 0.3.0 connecting container to a bridge purge ports with failed interfaces [It] DEL removes ports without network namespace 
/root/go/src/github.com/k8snetworkplumbingwg/ovs-cni/pkg/plugin/plugin_test.go:898
Ran 96 of 96 Specs in 41.027 seconds
FAIL! -- 95 Passed | 1 Failed | 0 Pending | 0 Skipped

a flake?

@phoracek
Bump to UBI 9
f7697a5 
Signed-off-by: Petr Horacek <phoracek@redhat.com>
@phoracek phoracek merged commit 2d464d0 into k8snetworkplumbingwg:main Jun 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e0ne e0ne e0ne approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phoracek @kubevirt-bot @e0ne