Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-51] baseline integration tests #8

Closed
wants to merge 7 commits into from
Closed

[GH-51] baseline integration tests #8

wants to merge 7 commits into from

Conversation

jeffbanks
Copy link
Contributor

Baseline kubectl authorization verification.

@jeffbanks jeffbanks self-assigned this Nov 3, 2020
@jeffbanks jeffbanks added the enhancement New feature or request label Nov 3, 2020
@jeffbanks jeffbanks requested a review from jsanda November 3, 2020 17:26
Copy link
Contributor

@jsanda jsanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a Go module for the tests? e.g.,

go mod init github.com/k8ssandra/k8ssandra/tests

tests/integration/cass_integration_test.go Outdated Show resolved Hide resolved
tests/integration/cass_integration_test.go Outdated Show resolved Hide resolved
@jeffbanks
Copy link
Contributor Author

Updates include:

  • Synchronizing util operations during cleanup along with timeout of delete when resources are not found/exist.
  • Cass-operator specific verification as baseline integration test.
  • Consistent use of namespace passed to util functions along with error detection and enhanced logging.
  • Module for test util for integration test support.

Copy link
Contributor

@jsanda jsanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are coming together nicely!

The one additional verification step I would like to see if checking that the CassandraDatacenter is ready.

@@ -0,0 +1,14 @@
module github.com/k8ssandra/k8ssandra/tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tests/integration/cass_integration_test.go Show resolved Hide resolved
@jeffbanks jeffbanks changed the title [K8C-18] baseline integration tests [GH-51] baseline integration tests Nov 19, 2020
@jeffbanks jeffbanks linked an issue Nov 19, 2020 that may be closed by this pull request
@jsanda jsanda mentioned this pull request Nov 22, 2020
@jeffbanks
Copy link
Contributor Author

Closing as this has been replaced with PR#105 for continued efforts with most recent set of changes post kubecon on master. Feedback and observations in this PR are bein addressed in the new PR.

@jeffbanks jeffbanks closed this Dec 1, 2020
@jdonenine jdonenine removed a link to an issue Dec 2, 2020
@jsanda jsanda added this to In progress in K8ssandra: Stargate Integration + Bug Fix via automation Dec 4, 2020
@jsanda jsanda added this to the Stargate Integration + Bug Fix milestone Dec 4, 2020
@jeffbanks
Copy link
Contributor Author

This work replaced with iterations of #105

@jeffbanks jeffbanks deleted the k8c-18 branch December 8, 2020 19:15
@jeffbanks jeffbanks moved this from In progress to Done in K8ssandra: Stargate Integration + Bug Fix Dec 8, 2020
@jeffbanks jeffbanks linked an issue Jan 8, 2021 that may be closed by this pull request
@jakerobb jakerobb mentioned this pull request Feb 2, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:medium enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Baseline integration test
4 participants