Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Testing Foundations #105

Closed
wants to merge 41 commits into from
Closed

Integration Testing Foundations #105

wants to merge 41 commits into from

Conversation

jeffbanks
Copy link
Contributor

Associated w/ efforts started with PR#8, re-based integration test branch with 200+ changes in main.

Work in-progress:

  • Migration of numerous test changes along with current master functionality.
  • Separation and cleanup of test util. module.
  • Modification of setup and teardown functions.

Remaining:

  • Enablement of cass-cluster verification post cass-operator setup.
  • Prometheus cleanup issue found during existing test run.
  • Logging reduction where necessary.

@jeffbanks jeffbanks self-assigned this Dec 1, 2020
@jeffbanks jeffbanks added this to In progress in K8ssandra: Stargate Integration + Bug Fix via automation Dec 1, 2020
@jeffbanks jeffbanks changed the title WIP: util mod enhancement; cass-op cleaner changes Integration Testing Foundations Dec 1, 2020
@jeffbanks jeffbanks mentioned this pull request Dec 1, 2020
Closed
jsanda
jsanda requested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@jsanda jsanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have more questions, butI need to make another, longer pass through the code first.

tests/integration/cass_integration_test.go Outdated Show resolved Hide resolved
tests/integration/cass_integration_test.go Outdated Show resolved Hide resolved
tests/integration/cass_integration_test.go Outdated Show resolved Hide resolved
K8ssandra: Stargate Integration + Bug Fix automation moved this from In progress to Review in progress Dec 2, 2020
jsanda
jsanda requested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@jsanda jsanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is what I would like to see for an initial integration test:

  • Install the k8ssandra chart
  • Install the k8ssandra-cluster chart
    • Use default setting to keep it simple
  • Verify that the CassandraDatacenter reaches the ready state
  • Uninstall the k8ssandra-cluster chart
  • Verify that the CassandraDatacenter has been deleted
  • Uninstall the k8ssandra chart
  • Verify that the cass-operator Deployment has been deleted.

tests/integration/util/lib.go Outdated Show resolved Hide resolved
tests/integration/cass_integration_test.go Outdated Show resolved Hide resolved
tests/integration/cass_integration_test.go Outdated Show resolved Hide resolved
tests/integration/cass_integration_test.go Outdated Show resolved Hide resolved
tests/integration/cass_integration_test.go Outdated Show resolved Hide resolved
@jdonenine jdonenine removed this from Review in progress in K8ssandra: Stargate Integration + Bug Fix Dec 2, 2020
@jdonenine jdonenine linked an issue Dec 2, 2020 that may be closed by this pull request
Baseline integration test #51
Closed
@jdonenine jdonenine moved this from Done to Review in progress in K8ssandra: Stargate Integration + Bug Fix Dec 2, 2020
jsanda
jsanda requested changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@jsanda jsanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the changes and patience. I know that there has been a lot of churn with this. In addition to the CassandraDatacenter verification, I would like to see the tests written using ginkgo.

tests/integration/operator_integration_test.go Outdated Show resolved Hide resolved
@jeffbanks
Copy link
Contributor Author

jeffbanks commented Dec 7, 2020 •
edited

Understand what we want here, the setup can be replaced with BeforeEach and use of Describe, Context, etc. available with Ginkgo.

@jeffbanks jeffbanks removed this from Review in progress in K8ssandra: Stargate Integration + Bug Fix Jan 19, 2021
@jeffbanks jeffbanks removed this from To do (P2) in K8ssandra Jan 19, 2021
@jeffbanks jeffbanks marked this pull request as draft February 11, 2021 15:11
@jdonenine jdonenine modified the milestones: Backlog, Expanded K8s Support + Automation Mar 2, 2021
@jdonenine jdonenine added this to Engineering To do in K8ssandra Mar 2, 2021
@jeffbanks
Copy link
Contributor Author

This effort is being addressed as part of #204 w/ release 1.0 components and new approach to integration tests.

@jeffbanks jeffbanks closed this Mar 3, 2021
K8ssandra automation moved this from Develoment To do to Done Mar 3, 2021
@jeffbanks jeffbanks deleted the operator-integration-tests branch March 3, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsanda jsanda Awaiting requested review from jsanda

@burmanm burmanm Awaiting requested review from burmanm

Assignees

@jeffbanks jeffbanks

Labels
complexity:high
Projects
No open projects
K8ssandra
  
Done
Milestone
Expanded K8s Support + Automation
Development

Successfully merging this pull request may close these issues.

Baseline integration test
4 participants
@jeffbanks @jsanda @burmanm @jdonenine