Cleanup 20230410 #193
Merged
Cleanup 20230410 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Romani <fromani@redhat.com>
Sched-related options were added as private fields for no good reason. Much like updater options, they should actually be public. Signed-off-by: Francesco Romani <fromani@redhat.com>
Aiming to continuously move logic from pkg/commands (which should just orchestrate) to logic-intensive package, move renderObjects, make it public along the way and fix inconsistencies in its API. Signed-off-by: Francesco Romani <fromani@redhat.com>
the error message was wrong for zero replicas. Signed-off-by: Francesco Romani <fromani@redhat.com>
kickstart the sched manifests tests with (very) basic coverage Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani
force-pushed
the
cleanup-20230410
branch
from
cd3a4e9
to
55612ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another grab-bag of minor fixes to cleanup the latest wave of PRs.