Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup 20230410 #193

Merged
merged 5 commits into from
Apr 10, 2023
Merged

Cleanup 20230410 #193

merged 5 commits into from
Apr 10, 2023

Commits on Apr 10, 2023

  1. commands: image: remove logic, push into package 

    Signed-off-by: Francesco Romani <fromani@redhat.com>
    @ffromani
    ffromani committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    70e0b06 View commit details
    Browse the repository at this point in the history

  2. commands: make sched options public 

    Sched-related options were added as private fields
for no good reason. Much like updater options, they
should actually be public.

Signed-off-by: Francesco Romani <fromani@redhat.com>
    @ffromani
    ffromani committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    2668c3a View commit details
    Browse the repository at this point in the history

  3. render: move helper into manifests pkg 

    Aiming to continuously move logic from pkg/commands (which
should just orchestrate) to logic-intensive package, move
renderObjects, make it public along the way and fix inconsistencies
in its API.

Signed-off-by: Francesco Romani <fromani@redhat.com>
    @ffromani
    ffromani committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    55ba858 View commit details
    Browse the repository at this point in the history

  4. manifests: sched: fix error message 

    the error message was wrong for zero replicas.

Signed-off-by: Francesco Romani <fromani@redhat.com>
    @ffromani
    ffromani committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    e16f20a View commit details
    Browse the repository at this point in the history

  5. manifests: sched: bootstrap tests 

    kickstart the sched manifests tests with (very) basic coverage

Signed-off-by: Francesco Romani <fromani@redhat.com>
    @ffromani
    ffromani committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    55612ac View commit details
    Browse the repository at this point in the history