-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more "acceptable errors" on repo initialization #696
Conversation
Signed-off-by: JesseBot <jessebot@linux.com>
Signed-off-by: JesseBot <jessebot@linux.com>
Closing because tests failed locally and I need to take a further look at this on my end before bothering maintainers. Sorry for the clutter. |
…verse Signed-off-by: JesseBot <jessebot@linux.com>
Just need someone to take a peek and then I can take a peek at #563 as well, because it still shows up in tests, but happens before my fix as well. Note: the e2e tests were not successful when I cloned master, so I've ignored them in testing this fix and instead tested directly with the method below. I haven't tested restoring from backups yet, but I did test both schedules (on a two minute cron schedule) and backups (just deleting and reapplying the backup resource) and they're completing/marked as succeeded, as well as I checked backblaze b2 and the data is being updated. My testing was just running EDIT: wrong issue, fixed to correct issue number, typos |
hi @jessebot I've triggered the pipeline here and the E2E tests seem to succeed. Were you able to verify, that this works with B2? If so this looks good to me. |
Yep, works with b2 for backups and schedules. Tested with annotated application aware backups for postgresql pvc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jessebot thanks for your contribution! 🎉 |
Summary
This is to fix this issue: #690
We currently only check for "already intitialized", but in the restic backend for backblaze b2, they also throw "config already exists" as a possible error for the same thing. Because both errors are possible and probably fine, I created an array, in case more show up in the future, for easier fixing.
Checklist
bug
,enhancement
,documentation
,change
,breaking
,as they show up in the changelog