KAA-1470. Fix Connectivity Checker test

kaaproject · Oct 26, 2016 · a6714a6 · a6714a6
1 parent a478578
commit a6714a6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...desktop/src/main/java/org/kaaproject/kaa/client/connectivity/PingConnectivityChecker.java b/...desktop/src/main/java/org/kaaproject/kaa/client/connectivity/PingConnectivityChecker.java
@@ -50,6 +50,7 @@ public boolean checkConnectivity() {
 
     try {
       try (Socket soc = new Socket()) {
+        // check if we can reach host (ping) thus we test connectivity
         soc.connect(new InetSocketAddress(host, DEFAULT_PORT), CONNECTION_TIMEOUT_MS);
       }
       return true;

diff --git a/...top/src/test/java/org/kaaproject/kaa/client/connectivity/PingConnectivityCheckerTest.java b/...top/src/test/java/org/kaaproject/kaa/client/connectivity/PingConnectivityCheckerTest.java
@@ -23,13 +23,13 @@ public class PingConnectivityCheckerTest {
 
   @Test
   public void checkConnectivityToWrongHostTest() {
-    PingConnectivityChecker pingConnectivityChecker = new PingConnectivityChecker("some-wrong-url=");
+    PingConnectivityChecker pingConnectivityChecker = new PingConnectivityChecker("wrong-host");
     Assert.assertFalse(pingConnectivityChecker.checkConnectivity());
   }
 
   @Test
-  public void checkConnectivityForLocalHostTest() {
-    PingConnectivityChecker pingConnectivityChecker = new PingConnectivityChecker("http://google.com");
+  public void checkConnectivityToSomeHostTest() {
+    PingConnectivityChecker pingConnectivityChecker = new PingConnectivityChecker("google.com");
     Assert.assertTrue(pingConnectivityChecker.checkConnectivity());
   }
 }