KAA-1146: quick fix for Admin UI.

kaaproject · Sep 2, 2016 · e3cb430 · e3cb430
1 parent 7b4dd0c
commit e3cb430
Show file tree

Hide file tree

Showing 7 changed files with 35 additions and 5 deletions.
diff --git a/.../src/main/java/org/kaaproject/kaa/server/admin/client/mvp/activity/CtlSchemaActivity.java b/.../src/main/java/org/kaaproject/kaa/server/admin/client/mvp/activity/CtlSchemaActivity.java
@@ -248,7 +248,7 @@ public void onClick(ClickEvent event) {
                         newPlace = new CtlSchemaPlace(place.getMetaInfoId(), version, place.getScope(), place.getApplicationId(), true, true);
                     } else if (place.getScope() == CTLSchemaScopeDto.TENANT) {
                         newPlace = new CtlSchemaPlace(place.getMetaInfoId(), version, place.getScope(),
-                                place.getEcfId(), place.getEcfVersionId(), place.getEcfVersion(), true, false);
+                                place.getEcfId(), place.getEcfVersionId(), place.getEcfVersion(), true, true);
                     }
                     newPlace.setPreviousPlace(place);
                     goTo(newPlace);

diff --git a/...src/main/java/org/kaaproject/kaa/server/admin/client/mvp/activity/EcfVersionActivity.java b/...src/main/java/org/kaaproject/kaa/server/admin/client/mvp/activity/EcfVersionActivity.java
@@ -55,6 +55,16 @@ public EcfVersionActivity(EcfVersionPlace place, ClientFactory clientFactory) {
         this.ecfVersionId = place.getEcfVersionId();
         initListView();
         this.listView.setPresenter(this);
+        setEnabledForAddButton();
+    }
+
+    private void setEnabledForAddButton() {
+        listView.addButton().setEnabled(false);
+        if (place.getEventClassDtoList() != null) {
+            if (!place.getEventClassDtoList().isEmpty()) {
+                listView.addButton().setEnabled(true);
+            }
+        }
     }
 
     private void initListView() {

diff --git a/...src/main/java/org/kaaproject/kaa/server/admin/client/mvp/data/EcfVersionDataProvider.java b/...src/main/java/org/kaaproject/kaa/server/admin/client/mvp/data/EcfVersionDataProvider.java
@@ -69,7 +69,7 @@ public void onSuccess(List<EventClassDto> result) {
                         EventClassDto eventClassDto = eventClassViewDto.getSchema();
                         eventClassDto.setCtlSchemaId(ctlSchemaMetaInfoDto.getId());
                         eventClassDto.setCreatedTime(System.currentTimeMillis());
-                        eventClassDto.setVersion(i);
+                        eventClassDto.setVersion(ctlSchemaMetaInfoDto.getVersions().get(ctlSchemaMetaInfoDto.getVersions().size()-1));
                         eventClassDto.setId(String.valueOf(i++));
                         eventClassDtoList.add(eventClassDto);
                     }

diff --git a/.../src/main/java/org/kaaproject/kaa/server/admin/client/mvp/view/base/BaseListViewImpl.java b/.../src/main/java/org/kaaproject/kaa/server/admin/client/mvp/view/base/BaseListViewImpl.java
@@ -52,7 +52,7 @@ interface BaseListViewImplUiBinder extends UiBinder<Widget, BaseListViewImpl<?>>
     @UiField public Label titleLabel;
     @UiField public HorizontalPanel buttonsPanel;
     @UiField public HorizontalPanel supportPanel;
-    @UiField (provided=true) public final ImageTextButton addButton;
+    @UiField (provided=true) public ImageTextButton addButton;
     @UiField (provided=true) public final AlertPanel errorPanel;
     @UiField (provided=true) public final KaaAdminStyle kaaAdminStyle;
     @UiField (provided=true) public final AvroUiStyle avroUiStyle;
@@ -65,7 +65,7 @@ interface BaseListViewImplUiBinder extends UiBinder<Widget, BaseListViewImpl<?>>
 
     public BaseListViewImpl(boolean editable) {
         this.editable = editable;
-        addButton = new ImageTextButton(Utils.resources.plus(), addButtonString());
+        initAddButton();
         errorPanel = new AlertPanel(Type.ERROR);
         kaaAdminStyle = Utils.kaaAdminStyle;
         avroUiStyle = Utils.avroUiStyle;
@@ -81,6 +81,10 @@ public BaseListViewImpl(boolean editable) {
 
         clearError();
     }
+
+    protected void initAddButton(){
+        addButton = new ImageTextButton(Utils.resources.plus(), addButtonString());
+    }
 
     protected void appendToolbarWidget(Widget widget) {
         buttonsPanel.setHorizontalAlignment(HasHorizontalAlignment.ALIGN_LEFT);

diff --git a/...c/main/java/org/kaaproject/kaa/server/admin/client/mvp/view/event/EcfVersionViewImpl.java b/...c/main/java/org/kaaproject/kaa/server/admin/client/mvp/view/event/EcfVersionViewImpl.java
@@ -41,6 +41,11 @@ public EcfVersionViewImpl(boolean editable) {
         supportPanel.add(addECButton);
     }
 
+    @Override
+    protected void initAddButton() {
+        addButton = new ImageTextButton(null, addButtonString());
+    }
+
     @Override
     protected AbstractGrid<EventClassDto, String> createGrid() {
         return new EcfVersionGrid();

diff --git a/...c/main/java/org/kaaproject/kaa/server/admin/client/mvp/view/event/EventClassViewImpl.java b/...c/main/java/org/kaaproject/kaa/server/admin/client/mvp/view/event/EventClassViewImpl.java
@@ -79,4 +79,13 @@ protected boolean validate() {
         result &= eventClassTypeName.getValue().length() > 0;
         return result;
     }
+
+    @Override
+    protected void updateSaveButton(boolean enabled, boolean invalid) {
+        if(create == true) {
+            super.updateSaveButton(enabled, invalid);
+        } else {
+            getSaveButtonWidget().setEnabled(false);
+        }
+    }
 }
diff --git a/...src/main/java/org/kaaproject/kaa/server/admin/client/mvp/view/widget/ImageTextButton.java b/...src/main/java/org/kaaproject/kaa/server/admin/client/mvp/view/widget/ImageTextButton.java
@@ -50,7 +50,9 @@ public ImageTextButton(ImageResource imageResource, String text, ClickHandler cl
                   spacing = 16;
           }
 
-          updateImageElementFromImageResource(imageSpan, imageResource, spacing);
+          if(imageResource != null) {
+            updateImageElementFromImageResource(imageSpan, imageResource, spacing);
+          }
           DOM.insertBefore(getElement(), imageSpan, DOM.getFirstChild(getElement()));
          }