Kaa 773 log delivery callbacks #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it is possible to setup per-test fixture based on group in which it included.
In order to support per-test setup()/teardown() procedures
Test structure improved as well
| typedef struct | ||
| { | ||
| uint16_t log_bucket_id; /**< ID of bucket present in storage. */ | ||
| kaa_time_t timeout; /**< bucket timeout */ |
There was a problem hiding this comment.
move timeout to start to avoid padding
Patch contains fixes for warnings from tests and API usage in various places as well.
Tests are included
|
|
||
|
|
||
| #define KAA_MAX_LOGS_IN_BUCKET 64 | ||
| #define KAA_MAX_BUCKET_SIZE 1024 |
There was a problem hiding this comment.
Please, check whether KAA_MAX_BUCKET_SIZE doesn't exceed the size of a OUT transport buffer.
See defaults.h
|
|
||
| /* Logging constraints */ | ||
| #define MAX_LOG_COUNT SIZE_MAX | ||
| #define MAX_LOG_BUCKET_SIZE (2 * 1024) |
There was a problem hiding this comment.
Please, check whether KAA_MAX_BUCKET_SIZE doesn't exceed the size of a OUT transport buffer.
See defaults.h
|
|
||
| if (((timeout_info_t *)data)->log_bucket_id == find_context->bucket_id) { | ||
| find_context->bucket_count++; |
There was a problem hiding this comment.
You need to return log_count from timeout_info_t instead.
|
LGTM |
|
|
||
| if (timeout_info->log_bucket_id == timeout_to_find->log_bucket_id) { |
There was a problem hiding this comment.
To avoid context state changes, please use kaa_list_find_next() to get the necessary info and kaa_list_remove_at() to remove the element
|
LGTM |
forGGe
added a commit
that referenced
this pull request
Jan 25, 2016
KAA-773: Log delivery callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: