Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitespace: add \r (windows EOL) to chars #606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msimerson
Copy link

@msimerson msimerson commented Mar 17, 2022

I've written a parser using builtins/whitespace and the Windows CI tests failed, because the EOL characters are \r instead of \n.

@kach
Copy link
Owner

kach commented Mar 18, 2022

Seems straightforward. Could you add a test for this, then I'll merge it?

@msimerson
Copy link
Author

The test is only going to work correctly on Windows, and a bunch more code changes are required in this repo before windows CI tests pass. I started down that road and its a slog.

@msimerson
Copy link
Author

related to #581

@msimerson
Copy link
Author

likely also related to #522

@msimerson
Copy link
Author

and related to #474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants