Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth with Github does not work #5

Closed
schmidsi opened this issue Jun 30, 2017 · 5 comments
Closed

OAuth with Github does not work #5

schmidsi opened this issue Jun 30, 2017 · 5 comments
Labels

Comments

@schmidsi
Copy link

Description

Sign-in using the browser does not work

Version

Kactus version: v0.1.0-alpha6
OS version: macOS Sierra Version 10.12.5 (16F73)

Steps to Reproduce

  1. Download Kaktus
  2. Open it
  3. Click on "Sign into GitHub.com"
  4. Click on "Sign in using your browser" --> The browser opens: https://github.com/login/oauth/authorize?client_id=
  5. Click on "Authorize Kactus"
  6. Browser goes to https://kactus.io/auth/github?code=f...

screen shot 2017-06-30 at 11 02 34

Expected behaviour:

  • Site is properly secured
  • The url somehow redirects so that the Kactus app receives the OAuth-Token

Actual behaviour:

  • Chrome brings a security warning
  • Site shows a 404 error

Reproduces how often:
100%

Logs

There are no logs. Here is an excerpt from: ~/Library/Application Support/Kactus

GPUCache
IndexedDB
Local Storage
Preferences
QuotaManager
QuotaManager-journal
SS -> /var/folders/mc/.../T/.io.kactus.KactusClient..../SS
SingletonCookie -> 4617403899741648914
SingletonLock -> simonschmids-macbook.local-...
databases
window-state.json
@schmidsi
Copy link
Author

Login with Username/Password + 2FA worked.

@mathieudutour
Copy link
Member

mathieudutour commented Jun 30, 2017

oops, should be x-kactus-auth://oauth. Will fix asap

@ahuk
Copy link

ahuk commented Jul 3, 2017

Same here, but the URL shown in Safari after granting access starts with
x-kactus-auth://oauth?code=

@mathieudutour
Copy link
Member

yep, just need to cut off a new release (I fixed the backend but didn't release the frontend yet), will do it today hopefully

@mathieudutour
Copy link
Member

fixed in 0.1.0

mathieudutour pushed a commit that referenced this issue Dec 24, 2017
Removes warning and fixes issues with permissions in development mode.
Fixes #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants