Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added neighbor info to blocks and phased out CHAIN_COUNT and NETWORK_ID env vars #2086

Merged
merged 6 commits into from
May 15, 2024

Conversation

MRVDH
Copy link
Contributor

@MRVDH MRVDH commented May 8, 2024


Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: b83bc66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@kadena/graph Patch
@kadena/explorer Patch
@kadena/graph-client Patch
@kadena/proof-of-us Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
proof-of-us ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 8:39am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback May 15, 2024 8:39am
marmalade-marketplace ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 8:39am
react-ui ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 8:39am
tools ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 8:39am

Copy link
Contributor

@nil-amrutlal nil-amrutlal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marmalade Simulation and Deployment are not working (discussed in person)

packages/apps/graph/src/devnet/deployment/helper.ts Outdated Show resolved Hide resolved
@nil-amrutlal
Copy link
Contributor

Command pnpm simulate:marmalade still does not work on my end. Can you please confirm

@MRVDH
Copy link
Contributor Author

MRVDH commented May 15, 2024

pnpm simulate:marmalade

Fixed now 👍

Comment on lines +40 to +43
await initializeNetworkConfig();

argumentConfig.network = networkData.networkId;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@MRVDH MRVDH merged commit 7e19fd3 into main May 15, 2024
15 checks passed
@MRVDH MRVDH deleted the feat/graph/neighbor-blocks-and-outphase-old-env-vars branch May 15, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants