Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cors ExposedHeaders #108

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Conversation

emmanueldenloye
Copy link
Contributor

No description provided.

@enobayram
Copy link
Contributor

I've verified this PR by making a /txs/account request and observing the expected new Access-Control-Expose-Headers header:

$ curl -v -H "Origin: example.com" "<cwd-url>/txs/account/k:f00e8e0fd5276ec62aeea0cd07b1d44bf737c5f63bca5d6ea22d69d71297d2f2?limit=1"
...
> GET /txs/account/k:f00e8e0fd5276ec62aeea0cd07b1d44bf737c5f63bca5d6ea22d69d71297d2f2?limit=1 HTTP/1.1
...
> Origin: example.com
> 
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Transfer-Encoding: chunked
< Date: Fri, 09 Dec 2022 22:51:50 GMT
< Server: Warp/3.3.20
< Content-Type: application/json;charset=utf-8
< Chainweb-Next: KDMyNzMxODMsIlNZX3F6RFBLMUU5Mi1LNWJ4SnZwcUpsNlFWUjl3N2tGbE5KZ0REYmMxZVUiLDAp
< Access-Control-Allow-Origin: *
< Access-Control-Expose-Headers: Chainweb-Next
...
[{"amount":5.81e-4,"height":3273183,"chainid":0,"blockHash":"0bc8ZxQtH6SPnZaKpu74rHDxERVlSV-lqHd1tmiejrE","requestKey":"SY_qzDPK1E92-K5bxJvpqJl6QVR9w7kFlNJgDDbc1eU","name":"coin","fromAccount":"k:f00e8e0fd5276ec62aeea0cd07b1d44bf737c5f63bca5d6ea22d69d71297d2f2","toAccount":"k:8372f0a8661247e39971ff2551a5e95de4110b8c090f5ddd93eb6fbb7d13d732","idx":0}]

Copy link
Contributor

@enobayram enobayram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@enobayram enobayram merged commit 1bdc54b into master Dec 9, 2022
@enobayram enobayram deleted the emmanuel/allow-header-chainweb-next branch December 9, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants