Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chainweb-Pact SPV Support #192

Merged
merged 130 commits into from
May 22, 2019
Merged

Chainweb-Pact SPV Support #192

merged 130 commits into from
May 22, 2019

Conversation

emilypi
Copy link
Member

@emilypi emilypi commented May 8, 2019

This PR stands up the tests and finishes the SPV integration between Chainweb and Pact.

Copy link
Contributor

@fosskers fosskers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally approved - @emilypi and I discussed some minor changes in person.

Copy link
Contributor

@sirlensalot sirlensalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with small changes, @larskuhtz or @fosskers should review too though for payload db etc

src/Chainweb/Pact/SPV.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/SPV.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/SPV.hs Show resolved Hide resolved
src/Chainweb/Pact/SPV.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Pact/Utils.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/CutDB.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/CutDB.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/CutDB.hs Outdated Show resolved Hide resolved
emilypi and others added 3 commits May 21, 2019 20:07
Co-Authored-By: Lars Kuhtz <lakuhtz@gmail.com>
Co-Authored-By: Lars Kuhtz <lakuhtz@gmail.com>
Co-Authored-By: Lars Kuhtz <lakuhtz@gmail.com>
@emilypi emilypi merged commit 6c326fe into master May 22, 2019
marklnichols pushed a commit that referenced this pull request May 22, 2019
* Add Chainweb-Pact SPV support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants