Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chainweb-Pact SPV Support #192

Merged
merged 130 commits into from May 22, 2019

Conversation

Projects
None yet
4 participants
@emilypi
Copy link
Contributor

commented May 8, 2019

This PR stands up the tests and finishes the SPV integration between Chainweb and Pact.

emilypi and others added some commits May 1, 2019

emilypi added some commits May 19, 2019

@fosskers
Copy link
Contributor

left a comment

Conditionally approved - @emilypi and I discussed some minor changes in person.

@slpopejoy
Copy link
Contributor

left a comment

Approved with small changes, @larskuhtz or @fosskers should review too though for payload db etc

Show resolved Hide resolved src/Chainweb/Pact/SPV.hs Outdated
Show resolved Hide resolved src/Chainweb/Pact/SPV.hs Outdated
Show resolved Hide resolved src/Chainweb/Pact/SPV.hs
Show resolved Hide resolved src/Chainweb/Pact/SPV.hs Outdated
Show resolved Hide resolved test/Chainweb/Test/Pact/Utils.hs Outdated

emilypi added some commits May 21, 2019

Show resolved Hide resolved test/Chainweb/Test/CutDB.hs Outdated
Show resolved Hide resolved test/Chainweb/Test/CutDB.hs Outdated
Show resolved Hide resolved test/Chainweb/Test/CutDB.hs Outdated

emilypi and others added some commits May 22, 2019

Update test/Chainweb/Test/CutDB.hs
Co-Authored-By: Lars Kuhtz <lakuhtz@gmail.com>
Update test/Chainweb/Test/CutDB.hs
Co-Authored-By: Lars Kuhtz <lakuhtz@gmail.com>
Update test/Chainweb/Test/CutDB.hs
Co-Authored-By: Lars Kuhtz <lakuhtz@gmail.com>

@emilypi emilypi merged commit 6c326fe into master May 22, 2019

1 check passed

ci/gitlab/gitlab.com Pipeline passed on GitLab
Details

marklnichols added a commit that referenced this pull request May 22, 2019

Chainweb-Pact SPV Support (#192)
* Add Chainweb-Pact SPV support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.