Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd SPV Handler to Pact Service #429
Merged
Conversation
…o/chainweb-node into emily/pact-spv-endpoint-pardeux
We're re-gossiping old transactions -- this change eagerly checks them, at the expense of moving the checkpointer more often.
…x-index
|
Merging to expedite release. If there are any issues, we can fix in a follow-on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilypi commentedSep 16, 2019
This PR uses Greg's tx index lookup to take a request key and produce an SPV transaction output proof. The workflow is as follows:
Lookup the index of the transaction on the current (source) chain, producing a block height and block hash.
Using the block height, lookup the specific index of the transaction in the block associated with that height.
Construct a transaction output proof using the SPV api for the given target chain id, at the blockheight associated with the transaction, at its index in the block.
Return this as unpadded B64url-encoded text.