Implement 'dec' for converting integers to decimals #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilypi
reviewed
Feb 24, 2023
|
I'm not happy with the naming of types in this PR. Expect changes soon. |
|
Also, this isn't something Pact developers should start using, if they can't deploy it on chain for another three months. A better answer for now may be to disable the warning -- or allow it to be disabled -- until this mitigation can appear on chain. |
emilypi
reviewed
May 1, 2023
|
Thank you for reminding me @emilypi, @rsoeldner is currently working on some tests that we will merge into this PR. |
emilypi
approved these changes
May 1, 2023
rsoeldner
approved these changes
May 1, 2023
|
This native needs to be gated on |
jmcardon
approved these changes
May 1, 2023
|
I will add the forking in #1195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.