Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inconsistent trace output #1153

Merged
merged 2 commits into from
Mar 21, 2023
Merged

fix inconsistent trace output #1153

merged 2 commits into from
Mar 21, 2023

Conversation

rsoeldner
Copy link
Member

No description provided.

@rsoeldner
Copy link
Member Author

@jwiegley not sure why tests are failing

@jwiegley
Copy link
Contributor

jwiegley commented Mar 8, 2023

Do the tests run locally?

@rsoeldner
Copy link
Member Author

The output fix propagated into the remote test. Test passes now.

@rsoeldner rsoeldner requested a review from jwiegley March 8, 2023 12:52
@rsoeldner rsoeldner mentioned this pull request Mar 21, 2023
Open
@emilypi emilypi merged commit 26779cc into master Mar 21, 2023
@rsoeldner rsoeldner deleted the rsoeldner/trace-output branch March 21, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilypi emilypi emilypi approved these changes

@jwiegley jwiegley Awaiting requested review from jwiegley jwiegley is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsoeldner @jwiegley @emilypi